Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 25, 2022

📜 Description

Fix: captureTransaction should return emptyId when transaction is discarded

💡 Motivation and Context

Fix #712

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #713 (00ccde1) into main (ea5c733) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         104      104           
  Lines        3335     3336    +1     
=======================================
+ Hits         3025     3026    +1     
  Misses        310      310           
Impacted Files Coverage Δ
dart/lib/src/sentry_client.dart 94.00% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5c733...00ccde1. Read the comment docs.

@marandaneto marandaneto merged commit 6206e85 into main Jan 25, 2022
@marandaneto marandaneto deleted the fix/captureTransaction-sentryid branch January 25, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry.captureTransaction should return Future<SentryId?> instead of Future<SentryId>

4 participants