Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Jan 18, 2022

📜 Description

Provide the autoFinishAfter duration in the constructor of SentryNavigatorObserver.

💡 Motivation and Context

Closes #667

💚 How did you test it?

Updated unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Jan 18, 2022
@denrase denrase changed the title Feat: Configure Idle Transaction Duration Feat: Configure idle transaction duration Jan 18, 2022
@denrase denrase marked this pull request as ready for review January 18, 2022 13:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #705 (a5dd161) into main (11b55fb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files         103      103           
  Lines        3259     3259           
=======================================
  Hits         2953     2953           
  Misses        306      306           
Impacted Files Coverage Δ
.../lib/src/navigation/sentry_navigator_observer.dart 98.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b55fb...a5dd161. Read the comment docs.

@marandaneto marandaneto merged commit 5f555b2 into main Jan 18, 2022
@marandaneto marandaneto deleted the feat/configure-idle-transaction-duration branch January 18, 2022 15:04
@marandaneto
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose auto transaction idle time via options

4 participants