Feat: Auto transactions duration trimming #702
Merged
+141
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 90.67% 90.70% +0.02%
==========================================
Files 104 104
Lines 3326 3335 +9
==========================================
+ Hits 3016 3025 +9
Misses 310 310 ☔ View full report in Codecov by Sentry. |
marandaneto
reviewed
Jan 17, 2022
marandaneto
reviewed
Jan 17, 2022
marandaneto
reviewed
Jan 17, 2022
marandaneto
reviewed
Jan 17, 2022
marandaneto
reviewed
Jan 17, 2022
denrase
changed the title
added 2 commits
January 18, 2022 13:31
denrase
changed the title
Contributor
|
@denrase we could also describe this behaviour in the docs https://docs.sentry.io/platforms/flutter/performance/instrumentation/automatic-instrumentation/#routing-instumentation |
Contributor
|
@brustolin would you like to review this one? we might need something similar on iOS soon, thanks. |
Contributor
|
@denrase there are conflicts other than that, all good. |
# Conflicts: # flutter/lib/src/navigation/sentry_navigator_observer.dart # flutter/test/sentry_navigator_observer_test.dart
marandaneto
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Introduce option to trim end of
Tracerroot span to last child span.💡 Motivation and Context
Automatic transactions from the
SentryNavigatorare always run for a fixed time, even though child spans might finish much sooner. With this PR, the longest running child span will also mark the end for the overall transaction.Closes #668
💚 How did you test it?
Added unit tests.
📝 Checklist
🔮 Next steps