Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Unreleased

* Fix: Use 'navigation' instead of 'ui.load' for auto transaction operation (#675)
* Fix: Use correct data/extras type in tracer (#693)

# 6.3.0-alpha.1

Expand Down
6 changes: 3 additions & 3 deletions dart/lib/src/sentry_tracer.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class SentryTracer extends ISentrySpan {

late final SentrySpan _rootSpan;
final List<SentrySpan> _children = [];
final Map<String, String> _extra = {};
final Map<String, dynamic> _extra = {};
Timer? _autoFinishAfterTimer;
var _finishStatus = SentryTracerFinishStatus.notFinishing();

Expand Down Expand Up @@ -81,7 +81,7 @@ class SentryTracer extends ISentrySpan {
}

@override
void setData(String key, value) {
void setData(String key, dynamic value) {
if (finished) {
return;
}
Expand Down Expand Up @@ -153,7 +153,7 @@ class SentryTracer extends ISentrySpan {
@override
DateTime? get endTimestamp => _rootSpan.endTimestamp;

Map<String, String> get data => Map.unmodifiable(_extra);
Map<String, dynamic> get data => Map.unmodifiable(_extra);

@override
bool get finished => _rootSpan.finished;
Expand Down
12 changes: 12 additions & 0 deletions dart/test/sentry_tracer_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,18 @@ void main() {
expect(tr.extra?['test'], isNull);
});

test('tracer sets non-string data to extra', () async {
final sut = fixture.getSut();

sut.setData('test', {'key': 'value'});

await sut.finish(status: SpanStatus.aborted());

final tr = fixture.hub.captureTransactionCalls.first;

expect(tr.extra?['test'], {'key': 'value'});
});

test('tracer starts child', () async {
final sut = fixture.getSut();

Expand Down