Skip to content

Conversation

@kuhnroyal
Copy link
Contributor

This is just a very quick PR for discussion.

📜 Description

  • add logger name parameter
  • log errors from Zone, Isolate and Flutter integrations

💡 Motivation and Context

Fixes #640

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

* add logger name parameter
* log errors from Zone, Isolate and Flutter integrations
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #641 (da4fdf1) into main (9599a50) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files          93       93           
  Lines        3035     3038    +3     
=======================================
+ Hits         2740     2743    +3     
  Misses        295      295           
Impacted Files Coverage Δ
dart/lib/src/diagnostic_logger.dart 16.66% <0.00%> (ø)
dart/lib/src/sentry_options.dart 91.80% <ø> (ø)
dart/lib/src/default_integrations.dart 100.00% <100.00%> (ø)
dart/lib/src/isolate_error_integration.dart 91.66% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9599a50...da4fdf1. Read the comment docs.

@kuhnroyal
Copy link
Contributor Author

The sentry_flutter builds seem to be failing because they don't use the correct dart dependency.

@marandaneto
Copy link
Contributor

@kuhnroyal CI fails ->

ERROR: ../lib/src/default_integrations.dart:77:11: Error: No named parameter with the name 'logger'.
ERROR: logger: 'sentry.flutterError',

@kuhnroyal kuhnroyal marked this pull request as ready for review November 25, 2021 11:47
@marandaneto
Copy link
Contributor

@kuhnroyal add changelog entry and its good to go, thanks for doing this

@marandaneto marandaneto merged commit c2941ed into getsentry:main Nov 26, 2021
@kuhnroyal kuhnroyal deleted the feature/log-integration-exceptions branch March 15, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider making Dart stack trace available in events

3 participants