-
-
Notifications
You must be signed in to change notification settings - Fork 276
Feat: Support for UserFeedback #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 91.77% 91.32% -0.45%
==========================================
Files 73 74 +1
Lines 2371 2422 +51
==========================================
+ Hits 2176 2212 +36
- Misses 195 210 +15 ☔ View full report in Codecov by Sentry. |
we actually don't need a UI at all, but its nice that you have added to the sample, so we can keep it. spec is here https://develop.sentry.dev/sdk/features/#user-feedback |
|
this PR branches from overall nice PR, unit tests and so on are missing but I like where this is going :) thanks @ueman |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good. Didn't check the dart details, though.
cba13f2 to
f6d2ad9
Compare
f6d2ad9 to
0988ed0
Compare
Co-authored-by: Manoel Aranda Neto <[email protected]>
|
The UI is in the example app for now. I do intend to clean it up and write tests for it in a follow-up PR. |
|
@ueman is it ready for final code review? @bruno-garcia or @philipphofmann will do it, thanks |
Yep, it's ready now. |
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Adds support for user feedback.
Builds on #505 and thus should be merged after it.
💡 Motivation and Context
Closes #215
💚 How did you test it?
📝 Checklist
🔮 Next steps