- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 276
          enh: refactor setTag and removeTag to FFI/JNI
          #3313
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files: 
 | 
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
+ Coverage   88.13%   89.57%   +1.44%     
==========================================
  Files         295       99     -196     
  Lines       10120     3406    -6714     
==========================================
- Hits         8919     3051    -5868     
+ Misses       1201      355     -846     ☔ View full report in Codecov by Sentry. | 
📜 Description
Part of moving away from method channels
💡 Motivation and Context
Partly completes #3204
💚 How did you test it?
Manual, integration tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps