Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 25, 2025

📜 Description

Part of moving away from method channels

💡 Motivation and Context

Partly completes #3204

💚 How did you test it?

Manual, integration tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.57%. Comparing base (d3fb366) to head (26a35ec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
+ Coverage   88.13%   89.57%   +1.44%     
==========================================
  Files         295       99     -196     
  Lines       10120     3406    -6714     
==========================================
- Hits         8919     3051    -5868     
+ Misses       1201      355     -846     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from enh/ffi-jni-contexts to main October 30, 2025 09:02
@buenaflor buenaflor marked this pull request as ready for review October 30, 2025 09:04
@buenaflor buenaflor merged commit bfabaf2 into main Oct 30, 2025
48 of 49 checks passed
@buenaflor buenaflor deleted the enh/ffi-jni-tags-set branch October 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants