enh: refactor setContexts and removeContexts to FFI/JNI
#3312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
+ Coverage 88.00% 88.25% +0.24%
==========================================
Files 296 295 -1
Lines 10244 10120 -124
==========================================
- Hits 9015 8931 -84
+ Misses 1229 1189 -40 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4481076 | 484.08 ms | 505.70 ms | 21.61 ms |
| f761369 | 462.73 ms | 563.80 ms | 101.06 ms |
| 75284dc | 512.39 ms | 530.87 ms | 18.48 ms |
| dbd526b | 504.88 ms | 569.02 ms | 64.15 ms |
| 7cfee3b | 498.78 ms | 516.98 ms | 18.20 ms |
| eca355d | 485.50 ms | 569.85 ms | 84.35 ms |
| c0dde50 | 464.13 ms | 472.10 ms | 7.98 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| e45c0e1 | 447.29 ms | 558.33 ms | 111.04 ms |
| 0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4481076 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| f761369 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 75284dc | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| dbd526b | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 7cfee3b | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| eca355d | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| c0dde50 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| e45c0e1 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
| e04b24b | 1230.22 ms | 1233.90 ms | 3.67 ms |
| 32914d8 | 1275.47 ms | 1285.20 ms | 9.73 ms |
| 73a3c38 | 1263.37 ms | 1277.90 ms | 14.53 ms |
| 5b9a0da | 1249.69 ms | 1250.71 ms | 1.03 ms |
| e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
| 8541716 | 1270.18 ms | 1271.80 ms | 1.62 ms |
| 9b99523 | 1256.06 ms | 1270.33 ms | 14.27 ms |
| a10aff4 | 1241.67 ms | 1255.02 ms | 13.35 ms |
| 0fb45d0 | 1273.24 ms | 1286.44 ms | 13.19 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| e04b24b | 5.53 MiB | 6.00 MiB | 480.00 KiB |
| 32914d8 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73a3c38 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 5b9a0da | 5.53 MiB | 5.96 MiB | 444.32 KiB |
| e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 8541716 | 5.53 MiB | 6.00 MiB | 479.96 KiB |
| 9b99523 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| a10aff4 | 5.53 MiB | 6.00 MiB | 486.71 KiB |
| 0fb45d0 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
buenaflor
commented
Oct 25, 2025
| # Remove native binding/bridge files from coverage. | ||
| # These FFI/JNI bindings are currently not unit tested due to limitations of FFI/JNI mocking. | ||
| dart run remove_from_coverage -f coverage/lcov.info -r 'binding.dart' | ||
| dart run remove_from_coverage -f coverage/lcov.info -r 'lib/src/native/sentry_native_channel.dart' |
There was a problem hiding this comment.
We can remove this from the coverage so CI doesn't complain.
We will eventually remove the file anyway as soon as we have moved away from method channels completely
denrase
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Part of moving away from method channels
💡 Motivation and Context
Partly closes #3204
💚 How did you test it?
Manual, integration test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps