-
-
Notifications
You must be signed in to change notification settings - Fork 271
Remove native frames integration #3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
==========================================
- Coverage 87.96% 87.68% -0.29%
==========================================
Files 287 287
Lines 9533 9710 +177
==========================================
+ Hits 8386 8514 +128
- Misses 1147 1196 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9b99523 | 1256.06 ms | 1270.33 ms | 14.27 ms |
73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
aeb02f2 | 1244.29 ms | 1256.55 ms | 12.26 ms |
73a3c38 | 1263.37 ms | 1277.90 ms | 14.53 ms |
6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
827bf09 | 1261.86 ms | 1276.41 ms | 14.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9b99523 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
aeb02f2 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
73a3c38 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
827bf09 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing.
@@ -1 +0,0 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting this file. this is not supposed to be here
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
827bf09 | 475.40 ms | 547.14 ms | 71.74 ms |
640ad0c | 466.00 ms | 552.67 ms | 86.67 ms |
aeb02f2 | 373.84 ms | 437.00 ms | 63.16 ms |
b6c8720 | 457.41 ms | 519.04 ms | 61.63 ms |
dbd526b | 504.88 ms | 569.02 ms | 64.15 ms |
2d34233 | 470.54 ms | 558.90 ms | 88.36 ms |
c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
73a3c38 | 478.18 ms | 526.62 ms | 48.44 ms |
ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
827bf09 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
640ad0c | 6.54 MiB | 7.69 MiB | 1.15 MiB |
aeb02f2 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
b6c8720 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
dbd526b | 6.54 MiB | 7.69 MiB | 1.15 MiB |
2d34233 | 6.54 MiB | 7.55 MiB | 1.01 MiB |
c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
73a3c38 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
📜 Description
This is currently unused and we already have a Flutter frames integration
💚 How did you test it?
Manual
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps