Skip to content

Conversation

buenaflor
Copy link
Contributor

📜 Description

This is currently unused and we already have a Flutter frames integration

💚 How did you test it?

Manual

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (73a3c38) to head (bc35ca7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   87.96%   87.68%   -0.29%     
==========================================
  Files         287      287              
  Lines        9533     9710     +177     
==========================================
+ Hits         8386     8514     +128     
- Misses       1147     1196      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

Copy link
Contributor

github-actions bot commented Jul 9, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.27 ms 1281.69 ms 16.43 ms
Size 7.86 MiB 9.44 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9b99523 1256.06 ms 1270.33 ms 14.27 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
0fb3800 1256.60 ms 1266.28 ms 9.68 ms
aeb02f2 1244.29 ms 1256.55 ms 12.26 ms
73a3c38 1263.37 ms 1277.90 ms 14.53 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms
2d34233 1258.19 ms 1268.92 ms 10.73 ms
e2d675d 1238.48 ms 1242.76 ms 4.28 ms
827bf09 1261.86 ms 1276.41 ms 14.55 ms

App size

Revision Plain With Sentry Diff
9b99523 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
0fb3800 7.86 MiB 9.44 MiB 1.58 MiB
aeb02f2 7.86 MiB 9.44 MiB 1.58 MiB
73a3c38 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB
2d34233 7.86 MiB 9.44 MiB 1.58 MiB
e2d675d 7.86 MiB 9.44 MiB 1.58 MiB
827bf09 7.86 MiB 9.44 MiB 1.58 MiB

Previous results on branch: enh/navigator-observer

Startup times

Revision Plain With Sentry Diff
9b55d5a 1270.14 ms 1280.02 ms 9.88 ms
2d5e180 1239.73 ms 1259.84 ms 20.11 ms

App size

Revision Plain With Sentry Diff
9b55d5a 7.86 MiB 9.44 MiB 1.58 MiB
2d5e180 7.86 MiB 9.44 MiB 1.58 MiB

Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing.

@@ -1 +0,0 @@

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleting this file. this is not supposed to be here

Copy link
Contributor

github-actions bot commented Jul 10, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 447.42 ms 508.33 ms 60.91 ms
Size 6.54 MiB 7.69 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2d675d 457.92 ms 529.17 ms 71.25 ms
827bf09 475.40 ms 547.14 ms 71.74 ms
640ad0c 466.00 ms 552.67 ms 86.67 ms
aeb02f2 373.84 ms 437.00 ms 63.16 ms
b6c8720 457.41 ms 519.04 ms 61.63 ms
dbd526b 504.88 ms 569.02 ms 64.15 ms
2d34233 470.54 ms 558.90 ms 88.36 ms
c8596a6 474.00 ms 492.96 ms 18.96 ms
73a3c38 478.18 ms 526.62 ms 48.44 ms
ec78888 457.94 ms 519.96 ms 62.02 ms

App size

Revision Plain With Sentry Diff
e2d675d 6.54 MiB 7.69 MiB 1.15 MiB
827bf09 6.54 MiB 7.53 MiB 1015.27 KiB
640ad0c 6.54 MiB 7.69 MiB 1.15 MiB
aeb02f2 6.54 MiB 7.69 MiB 1.15 MiB
b6c8720 6.54 MiB 7.69 MiB 1.15 MiB
dbd526b 6.54 MiB 7.69 MiB 1.15 MiB
2d34233 6.54 MiB 7.55 MiB 1.01 MiB
c8596a6 6.54 MiB 7.53 MiB 1015.27 KiB
73a3c38 6.54 MiB 7.69 MiB 1.15 MiB
ec78888 6.54 MiB 7.69 MiB 1.15 MiB

Previous results on branch: enh/navigator-observer

Startup times

Revision Plain With Sentry Diff
9b55d5a 458.68 ms 480.08 ms 21.40 ms
2d5e180 499.10 ms 535.89 ms 36.79 ms

App size

Revision Plain With Sentry Diff
9b55d5a 6.54 MiB 7.69 MiB 1.15 MiB
2d5e180 6.54 MiB 7.69 MiB 1.15 MiB

@buenaflor buenaflor requested a review from denrase July 10, 2025 15:26
@buenaflor buenaflor merged commit 793f4dc into main Jul 11, 2025
163 checks passed
@buenaflor buenaflor deleted the enh/navigator-observer branch July 11, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants