Skip to content

Remove workaround for Platform.executable #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Remove workaround for Platform.executable #2777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58ae6aa
Remove workaround for Platform.executable
denrase Mar 5, 2025
c69d998
add // ignore: deprecated_member_use
denrase Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dart/example_web/web/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Future<void> main() async {
Future<void> runApp() async {
print('runApp');

// ignore: deprecated_member_use
document.querySelector('#output')?.text = 'Your Dart app is running.';

await Sentry.addBreadcrumb(
Expand Down
16 changes: 1 addition & 15 deletions dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,7 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {

String? executable;
if (_options.sendDefaultPii) {
try {
// This throws sometimes for some reason
// https://github.com/flutter/flutter/issues/83921
executable = Platform.executable;
} catch (exception, stackTrace) {
_options.logger(
SentryLevel.error,
'Platform.executable couldn\'t be retrieved.',
exception: exception,
stackTrace: stackTrace,
);
if (_options.automatedTestMode) {
rethrow;
}
}
executable = Platform.executable;
}

return <String, dynamic>{
Expand Down
Loading