-
-
Notifications
You must be signed in to change notification settings - Fork 277
chore: flutter microbenchmarks #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
==========================================
+ Coverage 87.15% 92.00% +4.84%
==========================================
Files 266 89 -177
Lines 9447 3102 -6345
==========================================
- Hits 8234 2854 -5380
+ Misses 1213 248 -965 ☔ View full report in Codecov by Sentry. |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c732386 | 1233.20 ms | 1252.08 ms | 18.88 ms |
| 934f10e | 1245.18 ms | 1263.77 ms | 18.59 ms |
| dd933d4 | 1238.73 ms | 1252.43 ms | 13.70 ms |
| e3d9076 | 1203.68 ms | 1230.65 ms | 26.97 ms |
| 1b0c8a3 | 1259.30 ms | 1282.78 ms | 23.48 ms |
| 02661eb | 1244.45 ms | 1252.37 ms | 7.92 ms |
| 1a93825 | 1257.25 ms | 1261.55 ms | 4.30 ms |
| 00236a7 | 1250.06 ms | 1274.00 ms | 23.94 ms |
| 8a10ab7 | 1226.49 ms | 1250.52 ms | 24.03 ms |
| 3f23617 | 1261.93 ms | 1286.10 ms | 24.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c732386 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
| 934f10e | 8.38 MiB | 9.77 MiB | 1.39 MiB |
| dd933d4 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| e3d9076 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 1b0c8a3 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 02661eb | 8.42 MiB | 9.86 MiB | 1.44 MiB |
| 1a93825 | 8.28 MiB | 9.34 MiB | 1.05 MiB |
| 00236a7 | 8.38 MiB | 9.77 MiB | 1.39 MiB |
| 8a10ab7 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 3f23617 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4b943a1 | 348.17 ms | 437.15 ms | 88.98 ms |
| 1596141 | 300.92 ms | 368.94 ms | 68.02 ms |
| afa6e2a | 349.73 ms | 428.48 ms | 78.75 ms |
| 9e7630d | 449.43 ms | 475.82 ms | 26.39 ms |
| ee0ca56 | 355.35 ms | 421.13 ms | 65.78 ms |
| 07cd9e8 | 427.71 ms | 461.23 ms | 33.52 ms |
| 2e93bab | 515.33 ms | 558.79 ms | 43.46 ms |
| 9a5040f | 490.15 ms | 563.98 ms | 73.83 ms |
| f735167 | 404.38 ms | 412.57 ms | 8.19 ms |
| 3adbea9 | 395.16 ms | 447.88 ms | 52.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4b943a1 | 6.34 MiB | 7.28 MiB | 968.41 KiB |
| 1596141 | 6.16 MiB | 7.14 MiB | 1003.98 KiB |
| afa6e2a | 6.27 MiB | 7.20 MiB | 955.69 KiB |
| 9e7630d | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| ee0ca56 | 6.33 MiB | 7.30 MiB | 992.52 KiB |
| 07cd9e8 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 2e93bab | 6.49 MiB | 7.55 MiB | 1.07 MiB |
| 9a5040f | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| f735167 | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| 3adbea9 | 6.52 MiB | 7.61 MiB | 1.09 MiB |
buenaflor
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on replay I found myself needing to evaluate performance of possible solutions. This PR adds a scaffolding to run benchmarks as well as some benchmarks related to screenshot capture.
For reviewers: this is just
flutter create microbenchmarkswith updates to pubspec.yaml and lib/** + added the folder to the main package .pubignoreCurrent results from an old test device (Huawei Mate 20 Pro):
Images
Memory
#skip-changelog