-
-
Notifications
You must be signed in to change notification settings - Fork 277
ci: comment high risk only once #2414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
==========================================
+ Coverage 85.06% 85.95% +0.89%
==========================================
Files 257 81 -176
Lines 9191 2869 -6322
==========================================
- Hits 7818 2466 -5352
+ Misses 1373 403 -970 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2966d88 | 365.71 ms | 422.50 ms | 56.79 ms |
| affcf07 | 446.19 ms | 476.32 ms | 30.13 ms |
| fcd1ee4 | 298.96 ms | 376.04 ms | 77.09 ms |
| b47809a | 333.42 ms | 368.36 ms | 34.95 ms |
| c1bb00f | 303.77 ms | 371.88 ms | 68.11 ms |
| f770c4c | 385.88 ms | 449.86 ms | 63.98 ms |
| 3d305b9 | 403.55 ms | 469.76 ms | 66.20 ms |
| ea60f10 | 456.23 ms | 494.48 ms | 38.25 ms |
| 8609bd8 | 359.76 ms | 437.40 ms | 77.64 ms |
| 7748b7c | 356.37 ms | 426.70 ms | 70.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2966d88 | 6.33 MiB | 7.27 MiB | 954.11 KiB |
| affcf07 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| fcd1ee4 | 6.16 MiB | 7.13 MiB | 1000.85 KiB |
| b47809a | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| c1bb00f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| f770c4c | 6.33 MiB | 7.26 MiB | 950.37 KiB |
| 3d305b9 | 6.35 MiB | 7.35 MiB | 1021.16 KiB |
| ea60f10 | 6.49 MiB | 7.55 MiB | 1.07 MiB |
| 8609bd8 | 6.27 MiB | 7.20 MiB | 959.07 KiB |
| 7748b7c | 6.27 MiB | 7.20 MiB | 959.09 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f0fcbe1 | 1238.08 ms | 1243.44 ms | 5.36 ms |
| 0a23f98 | 1252.98 ms | 1276.76 ms | 23.78 ms |
| c978477 | 1228.43 ms | 1249.17 ms | 20.74 ms |
| a40bb7c | 1222.75 ms | 1240.88 ms | 18.13 ms |
| 6034b0a | 1244.89 ms | 1270.22 ms | 25.33 ms |
| ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
| ecb4003 | 1266.94 ms | 1290.24 ms | 23.31 ms |
| e0ba81f | 1240.27 ms | 1260.15 ms | 19.88 ms |
| d5fb969 | 1228.79 ms | 1256.17 ms | 27.38 ms |
| 7ec9238 | 1259.69 ms | 1281.59 ms | 21.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f0fcbe1 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 0a23f98 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| c978477 | 8.32 MiB | 9.50 MiB | 1.18 MiB |
| a40bb7c | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| 6034b0a | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
| ecb4003 | 8.09 MiB | 9.07 MiB | 1000.82 KiB |
| e0ba81f | 8.38 MiB | 9.71 MiB | 1.34 MiB |
| d5fb969 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 7ec9238 | 8.34 MiB | 9.65 MiB | 1.31 MiB |
brustolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #2413 all the duplicate comments are only noise
Tested this by checking if only one comment exists on multiple commits
#skip-changelog