Skip to content

Conversation

@martinhaintz
Copy link
Contributor

@martinhaintz martinhaintz commented Nov 12, 2024

📜 Description

updated the androidnativeplugin to 1.1.5

💡 Motivation and Context

close #2381

💚 How did you test it?

build it locally

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (13c8257) to head (a0b346d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
+ Coverage   85.04%   85.89%   +0.85%     
==========================================
  Files         257       81     -176     
  Lines        9194     2872    -6322     
==========================================
- Hits         7819     2467    -5352     
+ Misses       1375      405     -970     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 461.73 ms 498.21 ms 36.48 ms
Size 6.49 MiB 7.56 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2966d88 365.71 ms 422.50 ms 56.79 ms
affcf07 446.19 ms 476.32 ms 30.13 ms
fcd1ee4 298.96 ms 376.04 ms 77.09 ms
b47809a 333.42 ms 368.36 ms 34.95 ms
c1bb00f 303.77 ms 371.88 ms 68.11 ms
f770c4c 385.88 ms 449.86 ms 63.98 ms
3d305b9 403.55 ms 469.76 ms 66.20 ms
ea60f10 456.23 ms 494.48 ms 38.25 ms
8609bd8 359.76 ms 437.40 ms 77.64 ms
7748b7c 356.37 ms 426.70 ms 70.33 ms

App size

Revision Plain With Sentry Diff
2966d88 6.33 MiB 7.27 MiB 954.11 KiB
affcf07 6.52 MiB 7.59 MiB 1.06 MiB
fcd1ee4 6.16 MiB 7.13 MiB 1000.85 KiB
b47809a 5.94 MiB 6.96 MiB 1.02 MiB
c1bb00f 6.06 MiB 7.09 MiB 1.03 MiB
f770c4c 6.33 MiB 7.26 MiB 950.37 KiB
3d305b9 6.35 MiB 7.35 MiB 1021.16 KiB
ea60f10 6.49 MiB 7.55 MiB 1.07 MiB
8609bd8 6.27 MiB 7.20 MiB 959.07 KiB
7748b7c 6.27 MiB 7.20 MiB 959.09 KiB

Previous results on branch: fix/update-androidnativebundle-to-1.1.5

Startup times

Revision Plain With Sentry Diff
5fff553 353.44 ms 367.37 ms 13.93 ms

App size

Revision Plain With Sentry Diff
5fff553 6.49 MiB 7.56 MiB 1.07 MiB


- name: build apk
working-directory: ./flutter/example/android
run: flutter build apk --debug --target-platform=android-x64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was an optimization for CI build times. Any reason to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only added a few days ago by myself, because of the incompatibility of the latest flutter beta (3.27.0-0.1.pre) and the androidNativeBundle. The appending targe-platform was only a workaround to keep the ci pipeline working.
As the maintainer of the plugin fixed this incompatibility, I will revert the changes.
Here is the issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. On the other hand it does reduce build time by about 1.5 minute so I'd vote for keeping only the emulator build on. Your call

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does reduce build time then I guess it's worth keeping

@martinhaintz martinhaintz marked this pull request as ready for review November 13, 2024 10:02
@martinhaintz martinhaintz requested a review from vaind November 13, 2024 10:03
@martinhaintz martinhaintz enabled auto-merge (squash) November 13, 2024 10:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.90 ms 1266.40 ms 20.50 ms
Size 8.38 MiB 9.77 MiB 1.39 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f0fcbe1 1238.08 ms 1243.44 ms 5.36 ms
0a23f98 1252.98 ms 1276.76 ms 23.78 ms
c978477 1228.43 ms 1249.17 ms 20.74 ms
a40bb7c 1222.75 ms 1240.88 ms 18.13 ms
6034b0a 1244.89 ms 1270.22 ms 25.33 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
ecb4003 1266.94 ms 1290.24 ms 23.31 ms
e0ba81f 1240.27 ms 1260.15 ms 19.88 ms
d5fb969 1228.79 ms 1256.17 ms 27.38 ms
7ec9238 1259.69 ms 1281.59 ms 21.90 ms

App size

Revision Plain With Sentry Diff
f0fcbe1 8.29 MiB 9.38 MiB 1.09 MiB
0a23f98 8.10 MiB 9.18 MiB 1.08 MiB
c978477 8.32 MiB 9.50 MiB 1.18 MiB
a40bb7c 8.38 MiB 9.73 MiB 1.35 MiB
6034b0a 8.33 MiB 9.40 MiB 1.07 MiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
ecb4003 8.09 MiB 9.07 MiB 1000.82 KiB
e0ba81f 8.38 MiB 9.71 MiB 1.34 MiB
d5fb969 8.33 MiB 9.64 MiB 1.31 MiB
7ec9238 8.34 MiB 9.65 MiB 1.31 MiB

Previous results on branch: fix/update-androidnativebundle-to-1.1.5

Startup times

Revision Plain With Sentry Diff
5fff553 1238.53 ms 1258.22 ms 19.69 ms

App size

Revision Plain With Sentry Diff
5fff553 8.38 MiB 9.76 MiB 1.39 MiB

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as suggested let's keep --target-platform=android-x64 as it is (even though unintended) optimization

@martinhaintz martinhaintz merged commit be1723a into main Nov 18, 2024
42 checks passed
@martinhaintz martinhaintz deleted the fix/update-androidnativebundle-to-1.1.5 branch November 18, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ERROR] Sentry Example-App not building with latest Flutter Beta

4 participants