-
-
Notifications
You must be signed in to change notification settings - Fork 276
Support custom units for custom measurements #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom units for custom measurements #1181
Conversation
|
|
@marandaneto Do we also have to lowercase the custom measurements provided by constructor? Java does this: https://github.com/getsentry/sentry-java/blob/54cebc81e18ff2f50da062cac751681e7e4e83d4/sentry/src/test/java/io/sentry/MeasurementUnitTest.kt#L46 |
|
|
||
| - Feat: Introduce `Hint` data bag ([#1136](https://github.com/getsentry/sentry-dart/pull/1136)) | ||
| - Feat: Use `Hint` for screenshots ([#1165](https://github.com/getsentry/sentry-dart/pull/1165)) | ||
| - Feat: Support custom units for custom measurements ([#1181](https://github.com/getsentry/sentry-dart/pull/1181)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 The changelog entry seems to be part of an already released section
## 7.0.0.
Consider moving the entry to the## Unreleasedsection, please.
Codecov ReportBase: 76.27% // Head: 87.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## chore/bump-min-to-flutter-3.0.0-and-dart-2.17 #1181 +/- ##
==================================================================================
+ Coverage 76.27% 87.97% +11.69%
==================================================================================
Files 11 120 +109
Lines 333 3783 +3450
==================================================================================
+ Hits 254 3328 +3074
- Misses 79 455 +376
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looking at https://develop.sentry.dev/sdk/event-payloads/transaction/ I don't see anything in the spec. |
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment https://github.com/getsentry/sentry-dart/pull/1181/files#r1047071003 otherwise LGTM
…t/support-custom-units-for-custom-measurements
📜 Description
Closes #1053
💚 How did you test it?
📝 Checklist