Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Dec 12, 2022

📜 Description

Closes #1053

💚 How did you test it?

  • Unit Tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase changed the base branch from main to v7.0.0 December 12, 2022 14:40
@denrase denrase changed the base branch from v7.0.0 to chore/bump-min-to-flutter-3.0.0-and-dart-2.17 December 12, 2022 14:40
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3849fbd

@denrase
Copy link
Collaborator Author

denrase commented Dec 12, 2022

@marandaneto Do we also have to lowercase the custom measurements provided by constructor? Java does this: https://github.com/getsentry/sentry-java/blob/54cebc81e18ff2f50da062cac751681e7e4e83d4/sentry/src/test/java/io/sentry/MeasurementUnitTest.kt#L46


- Feat: Introduce `Hint` data bag ([#1136](https://github.com/getsentry/sentry-dart/pull/1136))
- Feat: Use `Hint` for screenshots ([#1165](https://github.com/getsentry/sentry-dart/pull/1165))
- Feat: Support custom units for custom measurements ([#1181](https://github.com/getsentry/sentry-dart/pull/1181))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 7.0.0.
    Consider moving the entry to the ## Unreleased section, please.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Base: 76.27% // Head: 87.97% // Increases project coverage by +11.69% 🎉

Coverage data is based on head (3849fbd) compared to base (4432728).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                                Coverage Diff                                 @@
##           chore/bump-min-to-flutter-3.0.0-and-dart-2.17    #1181       +/-   ##
==================================================================================
+ Coverage                                          76.27%   87.97%   +11.69%     
==================================================================================
  Files                                                 11      120      +109     
  Lines                                                333     3783     +3450     
==================================================================================
+ Hits                                                 254     3328     +3074     
- Misses                                                79      455      +376     
Impacted Files Coverage Δ
dart/lib/src/sentry_measurement.dart 100.00% <ø> (ø)
dart/lib/src/sentry_measurement_unit.dart 100.00% <100.00%> (ø)
dart/lib/src/sentry_client.dart 93.70% <0.00%> (ø)
dart/lib/src/http_client/tracing_client.dart 80.95% <0.00%> (ø)
dart/lib/src/sentry_envelope_item.dart 97.72% <0.00%> (ø)
dart/lib/src/transport/noop_transport.dart 0.00% <0.00%> (ø)
dart/lib/src/platform/_io_platform.dart 42.85% <0.00%> (ø)
dart/lib/src/sentry_traces_sampler.dart 93.33% <0.00%> (ø)
dart/lib/src/sentry.dart 85.71% <0.00%> (ø)
dart/lib/src/sentry_transaction_context.dart 95.23% <0.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto
Copy link
Contributor

@marandaneto Do we also have to lowercase the custom measurements provided by constructor? Java does this: getsentry/sentry-java@54cebc8/sentry/src/test/java/io/sentry/MeasurementUnitTest.kt#L46

Looking at https://develop.sentry.dev/sdk/event-payloads/transaction/ I don't see anything in the spec.
Maybe @romtsn can tell us if its written somewhere or the reasons?

@romtsn
Copy link
Member

romtsn commented Dec 12, 2022

Maybe @romtsn can tell us if its written somewhere or the reasons?

No specific reason, we just did not special-case it and used the same method apiName which lowercases the value. But looking at relay, they also lowercase it anyway, so I guess it doesn't matter what we send

@denrase denrase marked this pull request as ready for review December 12, 2022 16:22
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from chore/bump-min-to-flutter-3.0.0-and-dart-2.17 to v7.0.0 December 14, 2022 08:33
@marandaneto marandaneto merged commit c79671f into v7.0.0 Dec 14, 2022
@marandaneto marandaneto deleted the feat/support-custom-units-for-custom-measurements branch December 14, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom units for custom measurements

5 participants