-
-
Notifications
You must be signed in to change notification settings - Fork 276
Set custom measurements on transactions #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 89.99% 90.12% +0.12%
==========================================
Files 113 114 +1
Lines 3539 3554 +15
==========================================
+ Hits 3185 3203 +18
+ Misses 354 351 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a quick pass and added some comments on the API.
Co-authored-by: Philipp Hofmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Users are allowed to set custom measurements
💡 Motivation and Context
Fixes #789
getsentry/team-mobile#31
And getsentry/team-mobile#51
💚 How did you test it?
📝 Checklist
🔮 Next steps