-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Exposing SessionReplayIntegration to hybrid SDKs #4027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4027 +/- ##
=============================================
- Coverage 91.185% 91.137% -0.048%
=============================================
Files 611 610 -1
Lines 48069 47990 -79
Branches 17264 17206 -58
=============================================
- Hits 43832 43737 -95
- Misses 4144 4160 +16
Partials 93 93
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 51307b7 | 1223.08 ms | 1240.76 ms | 17.68 ms |
| ecd9ecd | 1204.67 ms | 1226.46 ms | 21.79 ms |
| f79ec31 | 1235.18 ms | 1255.38 ms | 20.20 ms |
| e998fd0 | 1254.41 ms | 1272.78 ms | 18.37 ms |
| 881a955 | 1221.63 ms | 1243.38 ms | 21.75 ms |
| 020745f | 1222.64 ms | 1253.54 ms | 30.90 ms |
| f1a6589 | 1253.67 ms | 1269.06 ms | 15.39 ms |
| 65290e0 | 1204.29 ms | 1217.00 ms | 12.71 ms |
| 72f0262 | 1199.73 ms | 1212.20 ms | 12.47 ms |
| e072ad1 | 1232.40 ms | 1253.19 ms | 20.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 51307b7 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
| ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
| f79ec31 | 21.58 KiB | 544.72 KiB | 523.14 KiB |
| e998fd0 | 21.58 KiB | 414.59 KiB | 393.01 KiB |
| 881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
| 020745f | 22.84 KiB | 403.13 KiB | 380.29 KiB |
| f1a6589 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
| 65290e0 | 21.58 KiB | 418.76 KiB | 397.18 KiB |
| 72f0262 | 21.58 KiB | 418.14 KiB | 396.56 KiB |
| e072ad1 | 21.58 KiB | 625.83 KiB | 604.24 KiB |
Previous results on branch: chore/exposing-sr-Hybrids
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bfc42d3 | 1243.22 ms | 1253.02 ms | 9.80 ms |
| a40d148 | 1240.84 ms | 1249.21 ms | 8.37 ms |
| 7c0b16d | 1232.80 ms | 1252.33 ms | 19.53 ms |
| 8769be0 | 1211.18 ms | 1231.14 ms | 19.96 ms |
| ecf1c33 | 1230.74 ms | 1242.70 ms | 11.96 ms |
| 8da6167 | 1219.49 ms | 1230.15 ms | 10.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bfc42d3 | 21.58 KiB | 656.16 KiB | 634.58 KiB |
| a40d148 | 21.58 KiB | 651.28 KiB | 629.70 KiB |
| 7c0b16d | 21.58 KiB | 656.18 KiB | 634.59 KiB |
| 8769be0 | 21.58 KiB | 669.82 KiB | 648.24 KiB |
| ecf1c33 | 21.58 KiB | 651.69 KiB | 630.11 KiB |
| 8da6167 | 21.58 KiB | 656.18 KiB | 634.59 KiB |
vaind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only reviewed the code without being able to test it in RN.
Sources/Sentry/include/HybridPublic/SentrySessionReplayIntegration-Hybrid.h
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentryReplayBreadcrumbConverter.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentrySRDefaultBreadcrumbConverter.swift
Show resolved
Hide resolved
Co-authored-by: Ivan Dlugos <[email protected]>
vaind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor changes I've suggested but this already works for RN so they're not mandatory
…ry-cocoa into chore/exposing-sr-Hybrids
…ry-cocoa into chore/exposing-sr-Hybrids
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now its possible to get a instance of SentrySessionReplayIntegration from
[PrivateSentrySDKOnly createReplayIntegration]To start the replay just call:
with the objects that control screenshot and breadcrumb conversion.
#skip-changelog