Skip to content

Conversation

@brustolin
Copy link
Contributor

Now its possible to get a instance of SentrySessionReplayIntegration from [PrivateSentrySDKOnly createReplayIntegration]

To start the replay just call:

- (void)startWithOptions:(SentryReplayOptions *)replayOptions
      screenshotProvider:(id<SentryViewScreenshotProvider>)screenshotProvider
     breadcrumbConverter:(id<SentryReplayBreadcrumbConverter>)breadcrumbConverter
             fullSession:(BOOL)shouldReplayFullSession;

with the objects that control screenshot and breadcrumb conversion.

#skip-changelog

@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.137%. Comparing base (beb7ff7) to head (8e7c690).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4027       +/-   ##
=============================================
- Coverage   91.185%   91.137%   -0.048%     
=============================================
  Files          611       610        -1     
  Lines        48069     47990       -79     
  Branches     17264     17206       -58     
=============================================
- Hits         43832     43737       -95     
- Misses        4144      4160       +16     
  Partials        93        93               
Files Coverage Δ
Sources/Sentry/SentrySessionReplay.m 87.790% <100.000%> (ø)
...ionReplay/SentrySRDefaultBreadcrumbConverter.swift 98.333% <100.000%> (ø)
...ons/Breadcrumbs/SentryBreadcrumbTrackerTests.swift 93.548% <100.000%> (ø)
...Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift 97.461% <100.000%> (ø)
...erformance/Network/SentryNetworkTrackerTests.swift 98.253% <100.000%> (ø)
...play/SentrySRDefaultBreadcrumbConverterTests.swift 100.000% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 98.561% <100.000%> (+0.010%) ⬆️
Sources/Sentry/SentrySessionReplayIntegration.m 90.909% <76.470%> (-4.028%) ⬇️
Sources/Sentry/PrivateSentrySDKOnly.mm 90.270% <73.684%> (-2.815%) ⬇️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb7ff7...8e7c690. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.96 ms 1227.84 ms 17.88 ms
Size 21.58 KiB 669.82 KiB 648.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
51307b7 1223.08 ms 1240.76 ms 17.68 ms
ecd9ecd 1204.67 ms 1226.46 ms 21.79 ms
f79ec31 1235.18 ms 1255.38 ms 20.20 ms
e998fd0 1254.41 ms 1272.78 ms 18.37 ms
881a955 1221.63 ms 1243.38 ms 21.75 ms
020745f 1222.64 ms 1253.54 ms 30.90 ms
f1a6589 1253.67 ms 1269.06 ms 15.39 ms
65290e0 1204.29 ms 1217.00 ms 12.71 ms
72f0262 1199.73 ms 1212.20 ms 12.47 ms
e072ad1 1232.40 ms 1253.19 ms 20.80 ms

App size

Revision Plain With Sentry Diff
51307b7 22.85 KiB 407.63 KiB 384.78 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
f79ec31 21.58 KiB 544.72 KiB 523.14 KiB
e998fd0 21.58 KiB 414.59 KiB 393.01 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
020745f 22.84 KiB 403.13 KiB 380.29 KiB
f1a6589 22.85 KiB 408.87 KiB 386.02 KiB
65290e0 21.58 KiB 418.76 KiB 397.18 KiB
72f0262 21.58 KiB 418.14 KiB 396.56 KiB
e072ad1 21.58 KiB 625.83 KiB 604.24 KiB

Previous results on branch: chore/exposing-sr-Hybrids

Startup times

Revision Plain With Sentry Diff
bfc42d3 1243.22 ms 1253.02 ms 9.80 ms
a40d148 1240.84 ms 1249.21 ms 8.37 ms
7c0b16d 1232.80 ms 1252.33 ms 19.53 ms
8769be0 1211.18 ms 1231.14 ms 19.96 ms
ecf1c33 1230.74 ms 1242.70 ms 11.96 ms
8da6167 1219.49 ms 1230.15 ms 10.66 ms

App size

Revision Plain With Sentry Diff
bfc42d3 21.58 KiB 656.16 KiB 634.58 KiB
a40d148 21.58 KiB 651.28 KiB 629.70 KiB
7c0b16d 21.58 KiB 656.18 KiB 634.59 KiB
8769be0 21.58 KiB 669.82 KiB 648.24 KiB
ecf1c33 21.58 KiB 651.69 KiB 630.11 KiB
8da6167 21.58 KiB 656.18 KiB 634.59 KiB

Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only reviewed the code without being able to test it in RN.

Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor changes I've suggested but this already works for RN so they're not mandatory

@brustolin brustolin marked this pull request as ready for review June 12, 2024 08:50
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit d9280ee into main Jun 12, 2024
@brustolin brustolin deleted the chore/exposing-sr-Hybrids branch June 12, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants