Skip to content

Conversation

@lforst
Copy link

@lforst lforst commented Nov 23, 2023

Effectively moves us over to the new npm binary distributions.

Changes:

  • Don't run install script on install
  • Emit console warning when install script is run
  • Refactor binary mock in tests to accommodate the new install process

Resolves #1360
Fixes #1758
Fixes #1640
Resolves #1348
Fixes getsentry/sentry-javascript#9545
Ref getsentry/sentry-javascript-bundler-plugins#412 (comment)

@lforst lforst marked this pull request as draft November 23, 2023 16:00
Base automatically changed from lforst-update-js-bin to master November 24, 2023 09:28
@lforst lforst marked this pull request as ready for review November 24, 2023 12:24
@lforst lforst requested review from AbhiPrasad and mydea November 24, 2023 12:24
"jest": "^27.5.1",
"npm-run-all": "^4.1.5",
"prettier": "^2.6.2"
"prettier": "2.8.8"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned this because CI and local were drifting apart for some reason. :/

@lforst lforst changed the title ref: Deprecate install script and don't run it on package install ref: Transition to binaries over npm Nov 24, 2023
@lforst
Copy link
Author

lforst commented Nov 27, 2023

Just verified with @bitsandfoxes on Windows and it works 👌

@lforst lforst merged commit f167a81 into master Nov 27, 2023
@lforst lforst deleted the lforst-remove-install-script branch November 27, 2023 13:49
@kamilogorek
Copy link
Contributor

https://i.pinimg.com/originals/bf/d6/d0/bfd6d06cf6af95c96be25204948f9b7a.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants