Recent changes to inject debug id code are making the process take a very long time

[vitorlopez]

Environment

What version of the CLI and what OS are you running?
2.20.4

Steps to Reproduce

• We have an Angular app that's not that big but we have 157 js files generated in the final bundle. Some of them are kinda large.

What you did?

• Upgraded package to latest version 2.20.4

Expected/Actual Result

What you thought would happen and what actually happened?
Injecting debug ids to be super fast like usual

Logs

Step #3: > Found 157 files
Step #3: > Analyzing 157 sources
Step #3: > Injecting debug ids

(....)

Step #3: Finalized release 2f98c493-b632-46e2-ab90-d47a0ba4c066
Step #3: Done in 637.26s.

For now I had to downgrade to version 2.20.3, because the new version it's taking ~10 minutes just to inject the ids. The same process takes 2 seconds on previous version.

[vitorlopez]

Relates to this #1693

[kamilogorek]

Is this CI or your local machine? And what OS? Would you be able to provide a repro case in some way maybe?

I just verified it locally on the Sentry itself, and I cannot reproduce it nowhere close to those numbers:

time sentry-cli sourcemaps inject dist
> Searching dist
> Found 1620 files
> Analyzing 1620 sources
> Injecting debug ids
> ...
sentry-cli sourcemaps inject dist  1.77s user 0.24s system 71% cpu 2.790 total

[AlexGanzer]

We have same issue on CI with version of Sentry CLI 2.20.4

-> Analyzing 41 sources
-> Injecting debug ids

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Sentry CLI version 2.20.3 works correctly

[vitorlopez]

I tested on a CI environment running Linux with Node 18 and my local environment on Mac running Node 18. Same results for both.

I'm pretty sure this not related to the number of files but with the files itself, there's something in that regex that's causing it to be super slow for some file contents. I have no ideia which files could be causing this specific slowness though, Angular generates some pretty large files sometimes.

[kamilogorek]

Do you think you'd be able to bisect your build files to find one that takes the longest? And then provide it (can be privately) for us to use as a repro case?

[vitorlopez]

I've narrowed it down to a single file. It's too large to send it here, How do you prefer for me share it, via email maybe?

[kamilogorek]

Works for me, hit me up at kamil@sentry.io

[kamilogorek]

@vitorlopez got your file, but still cannot repro this locally for some reason. We will need to spend some more time investigating this.

➜  ~/Downloads time sentry-cli sourcemaps inject sentry-file.js
> Searching sentry-file.js
> Found 1 file
> Analyzing 1 sources
> Analyzing completed in 0.045s
> Injecting debug ids

Source Map Debug ID Injection Report
  Modified: The following source files have been modified to have debug ids
    9af793d1-4b7d-5421-b284-9d6663720e1e - sentry-file.js

sentry-cli sourcemaps inject sentry-file.js  0.06s user 0.01s system 20% cpu 0.325 total
➜  ~/Downloads sentry-cli --version
sentry-cli 2.20.4

It's still useful, as the injection is not great there, so thanks for the repro!

[kamilogorek]

Even when trying to stress the cli with way more files, it doesnt budge:

➜  ~/repro ls -l tmp | wc -l
    2001
➜  ~/repro du -sh tmp
1.9G  tmp
➜  ~/Desktop time sentry-cli sourcemaps inject tmp
> Searching tmp
> Found 2000 files
> Analyzing 2000 sources
sentry-cli sourcemaps inject tmp  26.29s user 1.05s system 98% cpu 27.862 total

[vitorlopez]

If i delete all the other files and leave just this one, the process takes ~1 minutes (not 10 like I mentioned before, sorry for the confusion). But since I have several similar files the entire process takes 10 minutes. I have no idea what causes these files to take a lot longer than the others. The "Analyzing" step is really quick though:

> Found 157 files
> Analyzing 157 sources
> Analyzing completed in 0.065s
> Injecting debug ids

For now we'll keep using 2.20.3 where this process is incredibly fast. I'm sure there were good reasons for this change but version 2.20.3 works really well for us.

I hope you guys can find whatever is causing this issue. I'm pretty sure it'll happen for more angular apps using sentry-cli directly. Maybe it works with the webpack plugin, but since we're using esbuild for this app we can't really use the webpack plugin.

[mtariqsajid]

I test myself 2.20.3 is blazingly fast 2.20.4 is so slow it took around 320s to just make build before uploading to sentry
@kamilogorek

[wrongsahil]

We're also facing similar issue with 2.20.4. It almost took 1hr now for sentry-cli sourcemaps inject ./build to complete. Pinning it to 2.20.3 using curl -sL https://sentry.io/get-cli/ | SENTRY_CLI_VERSION="2.20.3" sh fixed the issue for now.

[ashbadger]

Just echo-ing what others have posted.

On 2.20.4, I'm experiencing the sourcemaps inject command taking roughly 60m for one of my codebases. The command hangs and nothing is logged during this hanging when I set Sentry logging to info mode via SENTRY_LOG_LEVEL=info.

I pinned the version to 2.20.3 and the command completed in <1s.