Fix/envelope transport tests #548
Conversation
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
maciejwalkowiak
changed the title
| /** | ||
| * Verifies is [SentryEnvelope] contains first event matching a predicate. | ||
| */ | ||
| inline fun checkEvent(noinline predicate: (SentryEvent) -> Unit): SentryEnvelope { |
There was a problem hiding this comment.
just out of curiosity, could this not live in the sentry-core/test package?
There was a problem hiding this comment.
Can it be then included in other modules? It wouldn't be straightforward with Maven. Perhaps there is a reasonable way to do it with Gradle?
There was a problem hiding this comment.
mm good catch, I thought testImplementation would be enough, but I think I've seen ways of doing that, just don't remember by heart now.
|
you can ignore |
|
@marandaneto could you please approve or tell what needs to be changed? Creating separate module has been suggested by @bruno-garcia. Having |
No description provided.