Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

feat: enable release health by default #534

Merged
merged 1 commit into from
Sep 1, 2020
Merged

feat: enable release health by default #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,13 @@ class ManifestMetadataReaderTest {
val options = SentryAndroidOptions()
val bundle = Bundle()
val mockContext = ContextUtilsTest.mockMetaData(metaData = bundle)
bundle.putBoolean(ManifestMetadataReader.SESSION_TRACKING_ENABLE, true)
bundle.putBoolean(ManifestMetadataReader.SESSION_TRACKING_ENABLE, false)

// Act
ManifestMetadataReader.applyMetadata(mockContext, options)

// Assert
assertTrue(options.isEnableSessionTracking)
assertFalse(options.isEnableSessionTracking)
}

@Test
Expand All @@ -117,7 +117,7 @@ class ManifestMetadataReaderTest {
ManifestMetadataReader.applyMetadata(mockContext, options)

// Assert
assertFalse(options.isEnableSessionTracking)
assertTrue(options.isEnableSessionTracking)
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions sentry-core/src/main/java/io/sentry/core/SentryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ public class SentryOptions {
*/
private boolean attachStacktrace;

/** Whether to enable automatic session tracking. */
private boolean enableSessionTracking;
/** Whether to enable or disable automatic session tracking. */
private boolean enableSessionTracking = true;

/**
* The session tracking interval in millis. This is the interval to end a session if the App goes
Expand Down
4 changes: 2 additions & 2 deletions sentry-samples/sentry-samples-android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@
<!-- how to set a custom release-->
<!-- <meta-data android:name="io.sentry.release" android:value="[email protected]+10001" />-->

<!-- how to enable automatic session tracking-->
<meta-data android:name="io.sentry.session-tracking.enable" android:value="true" />
<!-- how to disable automatic session tracking-->
<meta-data android:name="io.sentry.session-tracking.enable" android:value="false" />

<!-- how to set an environment-->
<!-- <meta-data android:name="io.sentry.environment" android:value="debug" />-->
Expand Down