Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Aug 30, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add sendDefaultPii flag to SentryOptions.
Filters out user information and sensitive request headers in Spring Boot integration if this flag is set to false.

💡 Motivation and Context

Discussion initially started when working on Spring Boot integration - we want to give users option to decide if detailed user information is sent or not - similar to how it's done in Python integration: https://docs.sentry.io/error-reporting/configuration/?platform=python

Supersedes #527.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Filters out user information and sensitive request headers in Spring Boot integration if this flag is set to false.
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bruno-garcia bruno-garcia merged commit 0a8bde6 into feat/sentry-java Aug 30, 2020
@bruno-garcia bruno-garcia deleted the add-send-default-pii branch August 30, 2020 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants