This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Refactor binding options #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
| "sentry.dsn=http://key@localhost/proj", | ||
| "sentry.read-timeout-millis=10", | ||
| "sentry.shutdown-timeout-millis=20", | ||
| "sentry.shutdown-timeout=20", |
There was a problem hiding this comment.
M: Should we name it millis instead for consistency?
There was a problem hiding this comment.
Yes but then we need to rename getter and setter too.
There was a problem hiding this comment.
@maciejwalkowiak I'd rename the getters/setters to keep consistency, as all the android confs on the manifest ends with -millis as well.
we could keep the current getters/setters as aliases and annotate them with:
@ApiStatus.ScheduledForRemoval
@Deprecated
or maybe not even that, as this is a major bump.
bruno-garcia
approved these changes
Aug 29, 2020
This was referenced Aug 30, 2020
maciejwalkowiak
added a commit
to maciejwalkowiak/sentry-android
that referenced
this pull request
Aug 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Bind to
SentryOptionin Logback & Spring integrations instead of custom classes.💡 Motivation and Context
After multiple try & errors with balancing between great user experience and ease of maintenance we came up with another option - just bind to
SentryOptionfor the price of showing some irrelevant properties in Spring Bootapplication.propertiesautocompletion.If it's decided to merge this one, we can close #528 and #529.
💚 How did you test it?
📝 Checklist
🔮 Next steps