-
-
Couldn't load subscription status.
- Fork 32
publish with craft #261
base: master
Are you sure you want to change the base?
publish with craft #261
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| github: | ||
| owner: getsentry | ||
| repo: sentry-android | ||
| targets: | ||
| - name: bintray | ||
| - name: github | ||
| - name: registry | ||
| type: sdk | ||
| config: | ||
| canonical: "maven:sentry-android" | ||
| - name: registry | ||
| type: sdk | ||
| config: | ||
| canonical: "maven:sentry-android-core" | ||
| - name: registry | ||
| type: sdk | ||
| config: | ||
| canonical: "maven:sentry-android-ndk" | ||
| - name: registry | ||
| type: sdk | ||
| config: | ||
| canonical: "maven:sentry-core" | ||
| statusProvider: | ||
| name: github |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/bin/bash | ||
| set -eux | ||
|
|
||
| SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | ||
| cd $SCRIPT_DIR/.. | ||
|
|
||
| OLD_VERSION="$1" | ||
| NEW_VERSION="$2" | ||
|
|
||
| # Add the new version | ||
| sed -i '' -e "s/val version = \"\(.*\)\" \/\/ updated by craft/val version = \"$NEW_VERSION\" \/\/ updated by craft/g" buildSrc/src/main/java/Config.kt | ||
| # Increment the buildVersionCode | ||
| perl -pi -e 's{val buildVersionCode = (\d+) // updated by craft}{$n=$1+1; "val buildVersionCode = $n // updated by craft"}e' buildSrc/src/main/java/Config.kt | ||
marandaneto marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/bash | ||
| set -eux | ||
|
|
||
| yarn global add @zeus-ci/cli | ||
|
|
||
| zeus upload -t "application/zip+aar" ./*/build/outputs/aar/*release.aar | ||
| zeus upload -t "application/zip+jar" ./*/build/libs/*release.jar | ||
|
Comment on lines
+6
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's about poms? eg There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The jars are all match the pattern. The pom is not because their names are all the same. I mentioned on slack. Wither we rename or find another way There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. true about the pom files, but not for sources and javadocs files as they have a |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend moving these properties away from here to https://github.com/getsentry/sentry-android/blob/master/gradle.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not much tbh, it's a key/value props file and it'd be easier to change with a CLI tool