Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .craft.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
github:
owner: getsentry
repo: sentry-android
targets:
- name: bintray
- name: github
- name: registry
type: sdk
config:
canonical: "maven:sentry-android"
- name: registry
type: sdk
config:
canonical: "maven:sentry-android-core"
- name: registry
type: sdk
config:
canonical: "maven:sentry-android-ndk"
- name: registry
type: sdk
config:
canonical: "maven:sentry-core"
statusProvider:
name: github
15 changes: 15 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ sudo: false
before_cache:
- rm -f $HOME/.gradle/caches/modules-2/modules-2.lock
- rm -fr $HOME/.gradle/caches/*/plugin-resolution/
branches:
only:
- master
- /^release\/.*$/
cache:
directories:
- $HOME/.gradle/caches/
Expand Down Expand Up @@ -32,3 +36,14 @@ matrix:
- jdk: openjdk8
after_success:
- bash <(curl -s https://codecov.io/bash)
notifications:
webhooks:
urls:
- https://zeus.ci/hooks/d904a9f8-490e-11ea-90b6-2a42b8bf05e4/public/provider/travis/webhook
on_success: always
on_failure: always
on_start: always
on_cancel: always
on_error: always
after_success:
- ./scripts/zeus.sh
6 changes: 2 additions & 4 deletions buildSrc/src/main/java/Config.kt
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ object Config {
object Sentry {
val SENTRY_CLIENT_NAME = "sentry.java.android"
val group = "io.sentry"
// TODO: change version to publish new version
val version = "2.0.0-rc03"
val version = "2.0.0-rc03" // updated by craft
val description = "SDK for sentry.io"
// TODO: change version code to publish new version, follow the pattern of `version`
val buildVersionCode = 20014
val buildVersionCode = 20014 // updated by craft
Comment on lines +52 to +54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend moving these properties away from here to https://github.com/getsentry/sentry-android/blob/master/gradle.properties

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much tbh, it's a key/value props file and it'd be easier to change with a CLI tool

val website = "https://sentry.io"
val userOrg = "getsentry"
val repoName = "sentry-android"
Expand Down
13 changes: 13 additions & 0 deletions scripts/bump-version.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/bin/bash
set -eux

SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
cd $SCRIPT_DIR/..

OLD_VERSION="$1"
NEW_VERSION="$2"

# Add the new version
sed -i '' -e "s/val version = \"\(.*\)\" \/\/ updated by craft/val version = \"$NEW_VERSION\" \/\/ updated by craft/g" buildSrc/src/main/java/Config.kt
# Increment the buildVersionCode
perl -pi -e 's{val buildVersionCode = (\d+) // updated by craft}{$n=$1+1; "val buildVersionCode = $n // updated by craft"}e' buildSrc/src/main/java/Config.kt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildVersionCode could be a hash from current date + incremental value, so it's easier to track. like sentry's semverish suggest, what do you think?

7 changes: 7 additions & 0 deletions scripts/zeus.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash
set -eux

yarn global add @zeus-ci/cli

zeus upload -t "application/zip+aar" ./*/build/outputs/aar/*release.aar
zeus upload -t "application/zip+jar" ./*/build/libs/*release.jar
Comment on lines +6 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's about poms? eg
build/publications/release/pom-default.xml
or even *javadocs.jar, *sources.jar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jars are all match the pattern. The pom is not because their names are all the same. I mentioned on slack. Wither we rename or find another way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true about the pom files, but not for sources and javadocs files as they have a *-sources.jar and *-javadocs.jar pattern if I recall it well.