Skip to content

Conversation

@cortinico
Copy link
Contributor

📜 Description

This PR adds 3 fields to the extension to offer filtering capabilities for variant/buildtypes/flavors:

                sentry {
                  ignoredVariants = ["..."]
                  ignoredBuildTypes = ["..."]
                  ignoredFlavors = ["..."]
                }

I refactored a bit the tests and created a new VariantTest integration test to test only this (otherwise adding flavors to the original test would have complicated task names unnecessarily).

💡 Motivation and Context

Fixes #18

💚 How did you test it?

Integration tests are included

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • No breaking changes

@cortinico cortinico requested a review from marandaneto July 6, 2021 09:10
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for doing this @cortinico , looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build variants support

2 participants