-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix fresh install of self-hosted for ARM by removing the --platform parameter #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Which images? Do we control them or are they third-party or ... ? Can you link where/why the platform option was added in the first place? What problem was it intended to solve and why are we confident that we're not regressing with this? |
chadwhitacre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
For more context, the images that I'm encountering issues with are from snuba, which doesn't support arm64 at the moment. |
|
error stack trace from ethanhs: |
|
I ran this in a clean clone and got: https://gist.github.com/chadwhitacre/27c0fc14b082e2a769a167113a092081 |
|
noting that there is a PR here to build an arm64 image for sentry that may help |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Note from @hubertdeng123 ... this does propagate into our self-hosted dogfood instance, so we can see if others are hitting this. |
|
note here: |
Fresh install of self-hosted was throwing an exception here on my M1 macbook pro:
This is happening in the installation process because certain images are only available for
linux/amd64and theplatformparameter here forces us to look for alinux/arm64image, eventually erroring out. For M1 macs, I don't think we can confidently assume the platform to belinux/arm64as long as we are runninglinux/amd64single arch images. For multi-arch images, docker should automatically pull in the image that matches the current OS and architecture.Github thread here for more context on a similar scenario:
docker/for-linux#1170 (comment)
Docker multi-arch support:
https://docs.docker.com/desktop/multi-arch/
Follow up on
#1538