do not use gosu for snuba-transactions-cleanup and snuba-cleanup #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I would say remove |
Collaborator
|
I could reproduce the issue (#1556) and also could verified removing @goganchic Do you want to change your PR to the solution I've said? |
Author
|
Ok, I'll try. |
goganchic
force-pushed
the
master
branch
2 times, most recently
from
0e94aa9 to
dbd00c2
Compare
Author
|
@aminvakil I've checked you suggestion locally: everything works fine. Changed PR as you said. |
Contributor
|
/gcbrun |
emmatyping
approved these changes
Jul 6, 2022
Contributor
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Thanks! I think this is the better way to resolve the error since they removed gosu from the Snuba image.
goganchic
changed the title
aminvakil
approved these changes
Jul 8, 2022
Collaborator
aminvakil
left a comment
aminvakil
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
BYK
approved these changes
Jul 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1556
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.