Improve installation through proxy #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
approved these changes
Jun 26, 2022
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
LGTM overall. I'd only argue the readme additions should now live under https://develop.sentry.dev/self-hosted/
Author
|
OK, I'd removed readme changes. Would you please tell me what repository should I make PR with readme changes to? |
Member
|
@goganchic you can put them somewhere under https://github.com/getsentry/develop/blob/master/src/docs/self-hosted/index.mdx (or any other page that looks meaningful to you) |
Member
|
/gcbrun |
Member
|
CI is hitting: https://github.com/getsentry/self-hosted/runs/7097597282?check_suite_focus=true#step:4:247 |
Fix in the case where vars are empty
Member
|
You good with a4751e8, @goganchic, et al.? /gcbrun |
Member
|
I'll merge this with my changes once CI finishes again ... |
Member
|
Sigh ... /gcbrun |
chadwhitacre
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1537
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.