refactor: make SourceView implement Sync #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Mar 8, 2024
src/sourceview.rs
Outdated
Comment on lines
143
to
144
| processed_until: Arc<Mutex<usize>>, | ||
| lines: Arc<Mutex<Vec<(*const u8, usize)>>>, |
There was a problem hiding this comment.
I don’t think we need any Arc here at all, a Mutex should suffice.
The first one can also be a AtomicUsize instead. I’m unsure why the previous code was using a RefCell instead of just a Cell.
|
While this is a change definitely worth having, long term, I would rather get rid of |
|
@Swatinem Thanks for your review, i already update code. If you merged this, could you publish a new version for this? Thank you for your work. |
Swatinem
approved these changes
Mar 11, 2024
|
@Swatinem Could you publish a new version for this? Thanks. |
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Oct 16, 2024
Previously, the sourcemap crate did not implement Send+Sync on `DecodedMap`, so we created unsafe wrappers around it and avoided unsafe behavior. Since getsentry/rust-sourcemap#80, this is no longer necessary. Test Plan: CI
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Oct 16, 2024
Previously, the sourcemap crate did not implement Send+Sync on `DecodedMap`, so we created unsafe wrappers around it and avoided unsafe behavior. Since getsentry/rust-sourcemap#80, this is no longer necessary. Test Plan: CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #79