perf: Avoid clone in adjust_mappings when possible
#125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
May 22, 2025
There was a problem hiding this comment.
On second thought though. self is being sorted by dst, whereas adjustment is sorted by src.
I’m unsure what the "natural" sort order of these tokens within sourcemaps is? depending on that, this optimization might just not be worth it if it turns out that it always needs to re-sort anyway.
| adjustment_tokens.sort_unstable_by_key(key); | ||
| Cow::Owned(adjustment_tokens) | ||
| }; | ||
| let adjustment_ranges = create_ranges(&adjustment_tokens, |t| (t.src_line, t.src_col)); |
There was a problem hiding this comment.
the adjustment_tokens are sorted by src, whereas the key fn defined above is sorted by dst, so this is a change in funcionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #124 (comment)