perf: Make SourceMapIndex::flatten more efficient
#121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I drafted the PR because the perf issue was rather let raw = builder.add(
token.get_dst_line() + off_line,
dst_col,
token.get_src_line(),
token.get_src_col(),
token.get_source(),
token.get_name(),
token.is_range(),
);which performs a hashmap operation due to |
Swatinem
reviewed
May 15, 2025
Swatinem
approved these changes
May 15, 2025
|
Thank you for a swift review! Can you publish a new version? |
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
May 16, 2025
### What? Update the `sourcemap` crate to the latest version. ### Why? To apply getsentry/rust-sourcemap#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can move sources and source contents beforehand, assuming we will use all sources anyway.