fix: Ensure text masking for updated attributes works #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Mar 17, 2023
| { | ||
| "id": 87, | ||
| "attributes": { | ||
| "value": "*** *****" |
Member
Author
There was a problem hiding this comment.
this was unmasked before the change, triggered by el.setAttribute('value', 'new value').
billyvg
approved these changes
Mar 17, 2023
mydea
force-pushed
the
fn/attribute-masking-updates
branch
from
305e1f8 to
c60b366
Compare
We had inconsistent casing for the tagName, leading to some masking slipping through.
mydea
force-pushed
the
fn/attribute-masking-updates
branch
from
c60b366 to
ed5c7a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had inconsistent casing for the tagName, leading to some masking slipping through.