feat: Add onMutation option to record
#70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Feb 28, 2023
| callbackWrapper((mutations) => { | ||
| // If this callback returns `false`, we do not want to process the mutations | ||
| // This can be used to e.g. do a manual full snapshot when mutations become too large, or similar. | ||
| if (options.onMutation && options.onMutation(mutations) === false) { |
Member
There was a problem hiding this comment.
And the idea is that we then trigger this full snapshot from the Replay integration, right?
Member
Author
There was a problem hiding this comment.
Jup, we can control what to do from replay then!
billyvg
approved these changes
Feb 28, 2023
billyvg
pushed a commit
that referenced
this pull request
Jul 24, 2023
billyvg
pushed a commit
that referenced
this pull request
Jul 29, 2023
Closed
billyvg
pushed a commit
that referenced
this pull request
Aug 7, 2023
billyvg
pushed a commit
that referenced
this pull request
Aug 7, 2023
billyvg
pushed a commit
that referenced
this pull request
Aug 8, 2023
billyvg
pushed a commit
that referenced
this pull request
Aug 30, 2023
Merged
billyvg
added a commit
that referenced
this pull request
Sep 21, 2023
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <[email protected]> Co-authored-by: mdellanoce <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <[email protected]> Co-authored-by: mdellanoce <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <[email protected]> Co-authored-by: mdellanoce <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this callback returns
false, we skip handling the mutations normally. It's up to the host app to do something with this then.Replaces #58