fix: Exclude modulepreload as well
#52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only excluding `<link rel="preload" as="script" />` but we should include `rel="modulepreload"` as well
mydea
approved these changes
Feb 14, 2023
Member
mydea
left a comment
mydea
left a comment
There was a problem hiding this comment.
LGTM! Two comments:
- I guess we can/should also PR this upstream?
- Does it make sense to extract this into a util to be re-used (e.g.
isPreloadLinkor something like this)
Member
Author
|
It's already merged :) rrweb-io#1128 |
Member
Author
|
Re: util function - I wanted to keep upstream PR small so opted to keep them inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only excluding
<link rel="preload" as="script" />but we should includerel="modulepreload"as well