fix: more robust rootShadowHost check
#50
Conversation
| const notInDoc = | ||
| !this.doc.contains(n) && | ||
| (rootShadowHost === null || !this.doc.contains(rootShadowHost)); | ||
| (!rootShadowHost || !this.doc.contains(rootShadowHost)); |
There was a problem hiding this comment.
Hmm would you mind explaining how this fixes the reported issue?
Not sure what I'm missing here but I tried reproducing this locally, by explicitly calling this.doc.contains(undefined) but the call seemed to return false and didn't crash.
Also, any chance that this is caused by the line above (n)?
There was a problem hiding this comment.
Ofc chances are that in my simple test app, doc is handling the contains call somewhat differently than in Sentry...
There was a problem hiding this comment.
ah, oof, I thought that contains(undefined) would break it. If that works, then this isn't a fix at all, then it obv. is a different issue. Then I guess we'd need to do a rootShadowHost instanceof Node check or something along these lines 🤔
|
Note this was reported upstream as well: rrweb-io#1114 |
|
https://github.com/rrweb-io/rrweb/pull/891/files This is a similar fix. |
Ah, interesting, so I guess we can merge this after all! |
|
Should fix getsentry/sentry-javascript#7274 |
This may be the underlying cause here, maybe an e.g.
undefinedsneaked in there somehow. IMHO this should also safe some bytes.