fix: masking on textarea #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If textarea has a child string content, it will get duplicated as a `value` attribute. Masking by text vs input can cause these two values to diverge (i.e. only one is masked). On playback, we remove duplicate textContent for textareas, which means we could show double textarea values: one masked, one unmasked.
billyvg
changed the base branch from
sentry-v1
to
feat-mask-placeholder-title-attributes
billyvg
changed the title
Lms24
approved these changes
Feb 7, 2023
packages/rrweb-snapshot/src/utils.ts
Outdated
| value: string | null; | ||
| maskInputFn?: MaskInputFn; | ||
| }): string { | ||
| console.log('maskInputValue', tagName) |
Member
There was a problem hiding this comment.
Do we want this log or is it a debugging leftover?
| assertSnapshot(snapshots); | ||
| }); | ||
|
|
||
| it.only('should mask only inputs', async () => { |
Member
Author
There was a problem hiding this comment.
Oops, what happens when I don't have precommit linters
mydea
approved these changes
Feb 8, 2023
Member
|
Merging this fix so it can go out with todays release! |
mydea
deleted the
feat-fix-mask-all-text-false-and-mask-all-inputs-textarea
branch
Member
|
damn, just noticed this doesn't go into develop, but into another feature branch 😅 hope I didn't mess anything up, sorry. I guess we can just fix this in the next release then 👍 |
billyvg
restored the
feat-fix-mask-all-text-false-and-mask-all-inputs-textarea
branch
billyvg
deleted the
feat-fix-mask-all-text-false-and-mask-all-inputs-textarea
branch
billyvg
added a commit
that referenced
this pull request
Feb 8, 2023
If textarea has a child string content, it will get duplicated as a `value` attribute. Masking by text vs input can cause these two values to diverge (i.e. only one is masked). On playback, we remove duplicate textContent for textareas, which means we could show double textarea values: one masked, one unmasked.
billyvg
added a commit
that referenced
this pull request
Feb 24, 2023
Fix bug introduced in #43 where we masked both textarea's `value` and `textContent`, which meant the text inside of the textarea would get duplicated. We can ignore `textContent` in this case and set it to an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If textarea has a child string content, it will get duplicated as a
valueattribute. Masking by text vs input can cause these two values to diverge (i.e. only one is masked). On playback, we remove duplicate textContent for textareas, which means we could show double textarea values: one masked, one unmasked.