feat(canvas): Add "maxCanvasSize" option for canvas #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a configuration option to set a max size for canvas snapshots. This will scale down canvas snapshot images if they are larger than the configure size limit. The size configuration is width * height.
billyvg
changed the title
size-limit report 📦
|
c298lee
approved these changes
Apr 12, 2024
mydea
reviewed
Apr 15, 2024
| const resizedBitmap = | ||
| targetWidth === width && targetHeight === height | ||
| ? bitmap | ||
| : // resize bitmap to fit within maxsize |
There was a problem hiding this comment.
what will happen if this is not supported? 🤔
There was a problem hiding this comment.
I'm not sure tbh, it could throw or it could ignore the options.
There was a problem hiding this comment.
My previous commit did the resizing manually with drawImage(), but I'd rather use the builtin since it's pretty well-supported. I think throwing and not capturing exceptions and in the other case, if it doesn't throw and just ignores the options and captures the original size, are both acceptable outcomes.
I'm going to merge as-is, but let me know what you think and I can follow-up.
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 15, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 15, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 18, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 22, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174 Closes #10498
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 22, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174 Closes #10498 Backport of #11617
mydea
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 23, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174 Closes #10498 Backport of #11617
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
This adds a configuration option to set a max size for canvas snapshots. This will scale down canvas snapshot images if they are larger than the configure size limit. The size configuration is width * height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration option to set a max size for canvas snapshots. This will scale down canvas snapshot images if they are larger than the configure size limit. The size configuration is width * height.