feat(suspect-commits): Add event cause events #117
Conversation
reload_app/events.py
Outdated
| "feature.event_cause.viewed": { | ||
| "org_id": int, | ||
| "project_id": int, | ||
| "platform": str, |
There was a problem hiding this comment.
okay removed platform
There was a problem hiding this comment.
never mind, @adhiraj said amplitude can't join data
There was a problem hiding this comment.
damn really? @adhiraj I thought we could do like project.platform?
reload_app/events.py
Outdated
| "org_id": int, | ||
| "plan": str, | ||
| }, | ||
| "feature.event_cause.viewed": { |
There was a problem hiding this comment.
not sure why we have a feature. prefix?
There was a problem hiding this comment.
hm ya not sure if this is for organizational reasons or if there's reporting that relies on it. I can remove the prefix
maheskett
force-pushed
the
maheskett/add-suspect-commit-analytics
branch
from
8ce327e to
d1a4d3d
Compare
| }, | ||
| "event_cause.viewed": { | ||
| "org_id": int, | ||
| "project_id": int, |
There was a problem hiding this comment.
why no platform here? basically i'm thinking if we wanna answer the question "what is the dismiss rate for different platforms?" what is the data we'll need
There was a problem hiding this comment.
that event is only going to reload. thought you could get the platform in that case?
There was a problem hiding this comment.
Yeah we can join project right?
maheskett
force-pushed
the
maheskett/add-suspect-commit-analytics
branch
from
d1a4d3d to
5225a2e
Compare
No description provided.