Skip to content

Conversation

@phacops
Copy link
Contributor

@phacops phacops commented Jan 18, 2024

Fixes #2873.

@phacops phacops requested a review from a team as a code owner January 18, 2024 23:00
@phacops phacops requested review from Dav1dde and jjbayer January 19, 2024 17:07
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what volume we're expecting for this change initially? Do SDKs already send this measurement in practice?

See comment about strings.py.

@phacops
Copy link
Contributor Author

phacops commented Jan 31, 2024

SDKs are not sending this measurement yet, volume will be 0 until the next release.

@phacops phacops enabled auto-merge (squash) January 31, 2024 23:46
@phacops phacops merged commit 0f7e3d4 into master Jan 31, 2024
@phacops phacops deleted the pierre/spans-inp-metrics branch January 31, 2024 23:51
Comment on lines +361 to +366
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turned out hackier than I thought, with all the cloning. We could instead create the pseudo-event before the retain_items loop, pass that into normalize() instead, and .take() measurements & spans in and out of that to prevent cloning. But I would not invest time into that, we should instead have a generic normalize_performance_score function that works on both spans and events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract INP and INP score from spans and into metrics

5 participants