-
Couldn't load subscription status.
- Fork 104
feat(spans): Extract INP metrics from spans #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what volume we're expecting for this change initially? Do SDKs already send this measurement in practice?
See comment about strings.py.
|
SDKs are not sending this measurement yet, volume will be 0 until the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turned out hackier than I thought, with all the cloning. We could instead create the pseudo-event before the retain_items loop, pass that into normalize() instead, and .take() measurements & spans in and out of that to prevent cloning. But I would not invest time into that, we should instead have a generic normalize_performance_score function that works on both spans and events.
Fixes #2873.