Skip to content

feat(crons): Add thresholds to monitor config payload #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat(crons): Add thresholds to monitor config payload #2842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51ca71b
feat(crons): Add thresholds to monitor config payload
rjo100 Dec 11, 2023
cc1e461
added changelog
rjo100 Dec 12, 2023
d3bd3e6
Update relay-monitors/src/lib.rs
rjo100 Dec 12, 2023
5b7f78a
Update relay-monitors/src/lib.rs
rjo100 Dec 12, 2023
ecc8196
Update relay-monitors/src/lib.rs
rjo100 Dec 12, 2023
9194310
Merge branch 'master' into rjo100/add-monitor-thresholds
rjo100 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Extract size metrics for all resource spans when permitted. ([#2805](https://github.com/getsentry/relay/pull/2805))
- Allow access to more fields in dynamic sampling and metric extraction. ([#2820](https://github.com/getsentry/relay/pull/2820))
- Add Redis set based cardinality limiter for metrics. ([#2745](https://github.com/getsentry/relay/pull/2745))
- Support issue thresholds for Cron Monitor configurations ([#2842](https://github.com/getsentry/relay/pull/2842))

**Bug Fixes**:

Expand Down
18 changes: 15 additions & 3 deletions relay-monitors/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,22 @@ pub struct MonitorConfig {
#[serde(default, skip_serializing_if = "Option::is_none")]
checkin_margin: Option<u64>,

/// How long (in minutes) is the checkin allowed to run for in in_rogress before it is
/// How long (in minutes) is the check-in allowed to run for in in_progress before it is
/// considered failed.
#[serde(default, skip_serializing_if = "Option::is_none")]
max_runtime: Option<u64>,

/// tz database style timezone string
#[serde(default, skip_serializing_if = "Option::is_none")]
timezone: Option<String>,

/// How many consecutive failed check-ins it takes to create an issue.
#[serde(default, skip_serializing_if = "Option::is_none")]
failure_issue_threshold: Option<u64>,

/// How many consecutive OK check-ins it takes to resolve an issue.
#[serde(default, skip_serializing_if = "Option::is_none")]
recovery_threshold: Option<u64>,
}

/// The trace context sent with a check-in.
Expand Down Expand Up @@ -289,7 +297,9 @@ mod tests {
},
"checkin_margin": 5,
"max_runtime": 10,
"timezone": "America/Los_Angles"
"timezone": "America/Los_Angles",
"failure_issue_threshold": 3,
"recovery_threshold": 1
}
}"#;

Expand All @@ -312,7 +322,9 @@ mod tests {
},
"checkin_margin": 5,
"max_runtime": 10,
"timezone": "America/Los_Angles"
"timezone": "America/Los_Angles",
"failure_issue_threshold": 3,
"recovery_threshold": 1
}
}"#;

Expand Down