Skip to content

feat(filter): Filter webkit error #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 5, 2023
Merged

feat(filter): Filter webkit error #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c32e672
wip
TBS1996 May 2, 2023
f2f5778
Merge branch 'master' into webkitfilter
TBS1996 May 2, 2023
fec1255
Merge branch 'master' into webkitfilter
TBS1996 May 30, 2023
21afd2b
wip
TBS1996 May 31, 2023
7eef32b
Merge branch 'master' into webkitfilter
TBS1996 May 31, 2023
d0ae358
wip
TBS1996 May 31, 2023
28819bb
Merge branch 'master' into webkitfilter
TBS1996 May 31, 2023
1c4ec1a
Merge branch 'master' into webkitfilter
TBS1996 Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
**Features**:

- Use different error message for empty strings in schema processing. ([#2151](https://github.com/getsentry/relay/pull/2151))
- Filter irrelevant webkit-issues. ([#2088](https://github.com/getsentry/relay/pull/2088))

## 23.5.1

Expand Down
4 changes: 3 additions & 1 deletion relay-filter/src/browser_extensions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ static EXTENSION_EXC_VALUES: Lazy<Regex> = Lazy::new(|| {
# See: https://forum.sentry.io/t/error-in-raven-js-plugin-setsuspendstate/481/
plugin\.setSuspendState\sis\snot\sa\sfunction|
# Chrome extension message passing failure
Extension\scontext\sinvalidated
Extension\scontext\sinvalidated|
webkit-masked-url:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have also hidden in there as requested in the linked issue? Or having only webkit-masked-url should be fine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way hidden is included seems a bit too irregular on the events here: getsentry/sentry-javascript#7993 (comment)

whereas almost all have in common webkit-masked-url:

if i want to include hidden then i think the pattern would be something like webkit-masked-url:.*hidden, but I'm not sure if theres a point to this because I don't think we will have false positives with the way this PR does it

"#,
)
.expect("Invalid browser extensions filter (Exec Vals) Regex")
Expand Down Expand Up @@ -250,6 +251,7 @@ mod tests {
"null is not an object (evaluating 'elt.parentNode')",
"plugin.setSuspendState is not a function",
"Extension context invalidated",
"useless error webkit-masked-url: please filter",
];

for exc_value in &exceptions {
Expand Down