sdk offline caching considerations #509
Conversation
bruno-garcia
requested review from
AbhiPrasad,
Swatinem,
jan-auer and
marandaneto
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/7Lvb29YFwVb8X7QLi4xpup8gqQP4 |
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
I guess this partly addresses #476
This is a drive-by review, I'll come back and actually try to help with content in a bit (shoot me a dm if I forget completely though lol)
Co-authored-by: Abhijeet Prasad <[email protected]>
Forgot about that issue. Agree it partially resolved, but I won't take on completing all items from it in this PR though. Lets get this bit reviewed and merge and cross off from the issue what's done |
| #### Example implementations | ||
|
|
||
| - [C#](https://github.com/getsentry/sentry-dotnet/blob/main/src/Sentry/Internal/Http/CachingTransport.cs) | ||
| - [Java](https://github.com/getsentry/sentry-java/blob/main/sentry/src/main/java/io/sentry/cache/EnvelopeCache.java) |
There was a problem hiding this comment.
Likely not the best class to be documented here, maybe AsyncHttpTransport or HttpConnection, the whole impl. is separated due to abstraction of Java/Android
There was a problem hiding this comment.
It's just a pointer to folks, didn't want to list all classes needed but something folks can find references from
No description provided.