REF: Outsource providers to xyzservices #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Collaborator
|
This looks great, merging! |
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Nov 21, 2024
So that xyzservices is also installed by default and `from xyzservices import TileProvider` can work. See geopandas/contextily#183
Draft
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also removed deprecated
urlandtileZoptions.While updating docs, I have removed unnecessary
to_string()when passing pyproj.CRS to add_basemap.There's currently no deprecation involved.
contextily.TileProviderwasn't a part of public API andcontextily.providerswork exactly the same as before.missing: