Hotfix/geoips

[Thinkscape]

Fix #267.

I've covered 100% of the API documentation, including all status and error codes and possible responses.

[staabm]

those files should not be ignored per project, but within your global git config on your machine.

[Thinkscape]

Well, yes. It's common practice in OSS projects, github auto-generates those etc. It's just a nice thing to have and helps contributors weed out unnecessary dirs. Not required and I'm not opinionated on it though.

[willdurand]

I'd rather prefer not to include this change, especially in this PR.

[Thinkscape]

ok

[willdurand]

great job overall!

[Thinkscape]

Thx Will.

[willdurand]

so now you can wrap everything on a same line :)

[willdurand]

You can squash your commits, and use PHP-CS-Fixer (just in case), and that will be perfect.

[Thinkscape]

Done.

[willdurand]

squash?

[Thinkscape]

I've already pushed.

[Thinkscape]

Unless you want a completely new branch, which means discussion will be lost.

[willdurand]

na, but I want a single commit, not 6..

[Thinkscape]

I can't rebase something that is already pushed. What I could do is rebase on a new branch and send new PR, but this will remove the diss. here.

[willdurand]

well you can:

git rebase -i HEAD~6

Then:

git push origin hotfix/geoips -f

[Thinkscape]

Strange, github accepted it.... ok then.

[willdurand]

Thanks!

[willdurand]

Release 2.3.2 includes this fix.