PB-1920: Fix AttributeError: '_thread._local' object has no attribute 'data' - #patch #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using the same
ThreadMappingContextobject in different threads throws aAttributeError: '_thread._local' object has no attribute 'data':Seems like the constructor is only executed in the thread the object is actually created but not in the other ones - not sure if this was different in Python versions <3.9. I've added a small helper that ensures that the
self.__localobjects have adataattribute before reading / writing. I've also added a test that actually tests if the data is thread-local (and that now passes without AttributeError).