-
Couldn't load subscription status.
- Fork 13
Make rules specific to Dart and Flutter #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rules specific to Dart and Flutter #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the AI rules in flutter.md to be specifically scoped to Dart and Flutter development. This is achieved by adding a conditional wrapper, making section headers more specific, and restructuring the document. The changelog and extension version are also updated to reflect these modifications. The changes are well-aligned with the goal of preventing these rules from applying to non-Flutter/Dart contexts. I have one suggestion to reconsider the removal of some general AI interaction guidelines which could improve the user experience.
flutter.md
Outdated
| - **Clarification:** If a request is ambiguous, ask for clarification on the | ||
| intended functionality and the target platform (e.g., command-line, web, | ||
| server). | ||
| <FLUTTER_DART_AI_RULES> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider following normal XML style, rather than using screaming caps here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that shouldn't affect the effectiveness. I was basing this on examples from other rules files, for example: https://github.com/gemini-cli-extensions/code-review/blob/main/commands/code-review.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm following this based of the "rules for rules" doc we use internally, so there seem to be different best practices here. This probably doesn't make a difference for the LLM though.
flutter.md
Outdated
| `lib/main.dart` as the primary application entry point. | ||
|
|
||
| ## Flutter style guide | ||
| ## Flutter Style Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use sentence case for headings and titles, as per our developer doc style guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. This was the exception, which is why I changed it, but I'll make all the rest conform.
|
@johnpryan PTAL: I made the changes you wanted, and added some begging. |
Description
This modifies the rules file so that it makes it clear what it applies to, so that just having the flutter.md file won't poison other kinds of development sessions with Flutter suggestions.
Testing
Tested by running and asking it how to do theme management in a non-flutter web app.