Skip to content

Conversation

@gspencergoog
Copy link
Contributor

Description

This modifies the rules file so that it makes it clear what it applies to, so that just having the flutter.md file won't poison other kinds of development sessions with Flutter suggestions.

Testing

Tested by running and asking it how to do theme management in a non-flutter web app.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AI rules in flutter.md to be specifically scoped to Dart and Flutter development. This is achieved by adding a conditional wrapper, making section headers more specific, and restructuring the document. The changelog and extension version are also updated to reflect these modifications. The changes are well-aligned with the goal of preventing these rules from applying to non-Flutter/Dart contexts. I have one suggestion to reconsider the removal of some general AI interaction guidelines which could improve the user experience.

flutter.md Outdated
- **Clarification:** If a request is ambiguous, ask for clarification on the
intended functionality and the target platform (e.g., command-line, web,
server).
<FLUTTER_DART_AI_RULES>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider following normal XML style, rather than using screaming caps here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that shouldn't affect the effectiveness. I was basing this on examples from other rules files, for example: https://github.com/gemini-cli-extensions/code-review/blob/main/commands/code-review.toml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following this based of the "rules for rules" doc we use internally, so there seem to be different best practices here. This probably doesn't make a difference for the LLM though.

flutter.md Outdated
`lib/main.dart` as the primary application entry point.

## Flutter style guide
## Flutter Style Guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sentence case for headings and titles, as per our developer doc style guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. This was the exception, which is why I changed it, but I'll make all the rest conform.

@gspencergoog
Copy link
Contributor Author

@johnpryan PTAL: I made the changes you wanted, and added some begging.

@gspencergoog gspencergoog merged commit 171e37a into gemini-cli-extensions:main Oct 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants