Skip to content

Consistently access facts via the ansible_facts.* namespace #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Consistently access facts via the ansible_facts.* namespace #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c33b70
ci: disable injecting facts as own vars in the main namespace
Normo Aug 20, 2025
c106b00
Consistently access facts via the ansible_facts.* namespace
Normo Aug 20, 2025
db95589
Revert "ci: disable injecting facts as own vars in the main namespace"
Normo Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ postgresql_user: postgres
postgresql_group: postgres

# `md5` or `scram-sha-256` (https://www.postgresql.org/docs/10/auth-methods.html)
postgresql_auth_method: "{{ ansible_fips | ternary('scram-sha-256', 'md5') }}"
postgresql_auth_method: "{{ ansible_facts.fips | ternary('scram-sha-256', 'md5') }}"

postgresql_unix_socket_directories:
- /var/run/postgresql
Expand Down
6 changes: 3 additions & 3 deletions molecule/default/converge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
lc_collate: 'C.UTF-8'
lc_ctype: 'C.UTF-8'
when:
- ( ansible_distribution == 'Fedora' and ansible_distribution_major_version >= '30') or
( ansible_os_family == 'RedHat' and ansible_distribution_major_version in ['8','9'])
- ( ansible_facts.distribution == 'Fedora' and ansible_facts.distribution_major_version >= '30') or
( ansible_facts.os_family == 'RedHat' and ansible_facts.distribution_major_version in ['8','9'])

- name: Update apt cache.
apt: update_cache=true cache_valid_time=600
changed_when: false
when: ansible_os_family == 'Debian'
when: ansible_facts.os_family == 'Debian'

roles:
- role: geerlingguy.postgresql
Expand Down
6 changes: 3 additions & 3 deletions tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

# Setup/install tasks.
- include_tasks: setup-Archlinux.yml
when: ansible_os_family == 'Archlinux'
when: ansible_facts.os_family == 'Archlinux'

- include_tasks: setup-Debian.yml
when: ansible_os_family == 'Debian'
when: ansible_facts.os_family == 'Debian'

- include_tasks: setup-RedHat.yml
when: ansible_os_family == 'RedHat'
when: ansible_facts.os_family == 'RedHat'

- include_tasks: initialize.yml
- include_tasks: configure.yml
Expand Down
20 changes: 10 additions & 10 deletions tasks/variables.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
---
# Variable configuration.
- name: Include OS-specific variables (Debian).
include_vars: "{{ ansible_distribution }}-{{ ansible_distribution_version.split('.')[0] }}.yml"
when: ansible_os_family == 'Debian'
include_vars: "{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_version.split('.')[0] }}.yml"
when: ansible_facts.os_family == 'Debian'

- name: Include OS-specific variables (RedHat).
include_vars: "{{ ansible_os_family }}-{{ ansible_distribution_version.split('.')[0] }}.yml"
include_vars: "{{ ansible_facts.os_family }}-{{ ansible_facts.distribution_version.split('.')[0] }}.yml"
when:
- ansible_os_family == 'RedHat'
- ansible_distribution != 'Fedora'
- ansible_distribution != 'Amazon'
- ansible_facts.os_family == 'RedHat'
- ansible_facts.distribution != 'Fedora'
- ansible_facts.distribution != 'Amazon'

- name: Include OS-specific variables (Amazon).
include_vars: "{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml"
when: ansible_distribution == 'Amazon'
include_vars: "{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_major_version }}.yml"
when: ansible_facts.distribution == 'Amazon'

- name: Include OS-specific variables (Fedora).
include_vars: "{{ ansible_distribution }}-{{ ansible_distribution_version.split('.')[0] }}.yml"
when: ansible_distribution == 'Fedora'
include_vars: "{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_version.split('.')[0] }}.yml"
when: ansible_facts.distribution == 'Fedora'

- name: Define postgresql_packages.
set_fact:
Expand Down
Loading