Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@Panda-Program-Web
Copy link
Contributor

@Panda-Program-Web Panda-Program-Web commented Jan 19, 2020

概要

https://www.gatsbyjs.org/docs/unit-testing/ を翻訳しました。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 19, 2020
`jest-preprocess.js`. You may need to enable some of the plugins used by Gatsby,
though remember you may need to install the Babel 7 versions. See
[the Gatsby Babel config guide](/docs/babel) for some examples.
If you need to make changes to your Babel config, you can edit the config in `jest-preprocess.js`. You may need to enable some of the plugins used by Gatsby, though remember you may need to install the Babel 7 versions. See [the Gatsby Babel config guide](/docs/babel) for some examples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳前の文が残ってしまっているようです

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

削除しました👍

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KushibikiMashu PR ありがとうございます!いくつか Suggest したので確認お願いします。

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
@Naturalclar
Copy link
Contributor

@KushibikiMashu こちら、suggestion の確認はできましたでしょうか。

@uetchy uetchy added the stale? A pull request that is seemingly abandoned by author label Feb 9, 2020
@Panda-Program-Web
Copy link
Contributor Author

Suggestionありがとうございます。取り込みました👍
また、コメントいただいた分も修正してpushしました!

@Panda-Program-Web Panda-Program-Web force-pushed the translate-docs-unit-testing branch from 2735097 to 385105f Compare February 15, 2020 07:06
@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed stale? A pull request that is seemingly abandoned by author status: awaiting author response A pull request that is awaiting author's response labels Feb 15, 2020
@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 15, 2020
Naturalclar
Naturalclar previously approved these changes Feb 15, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KushibikiMashu
残りのSuggestion対応されれば問題なさそうです:+1:

@Panda-Program-Web
Copy link
Contributor Author

Suggestionありがとうございました。取り込みました!

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます 👍

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 16, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@uetchy uetchy merged commit 2954bd9 into gatsbyjs:master Feb 16, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 16, 2020

Holy buckets, @KushibikiMashu — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants