Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@tkt989
Copy link
Contributor

@tkt989 tkt989 commented Jan 19, 2020

概要

https://www.gatsbyjs.org/docs/sharing-components-across-websites/ の翻訳対応しました。
レビューよろしくお願いします🙇

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 19, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます👍

@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
@tkt989
Copy link
Contributor Author

tkt989 commented Jan 27, 2020

@uetchy
レビューありがとうございます!
修正内容を反映しました。
ご確認お願いします。

@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 27, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います!一点 Lint で落ちてる部分だけ修正お願いします

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 27, 2020
@tkt989
Copy link
Contributor Author

tkt989 commented Jan 27, 2020

@Naturalclar
修正を反映させていただきました。
よろしくお願いします🙇

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 27, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@Naturalclar Naturalclar merged commit 6391334 into gatsbyjs:master Feb 1, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants