Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Conversation

@nzws
Copy link
Contributor

@nzws nzws commented Jan 18, 2020

概要

docs/sourcing-from-private-apis.md を翻訳しました。よろしくお願いいたします🙏

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました(推奨)
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 18, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的に素晴らしいです👍

Gatsby は、ヘッドレス CMS、データベース、SaaS サービス、パブリック API、プライベート API からデータを取得できます。

From the Gatsby perspective, there is no difference between sourcing from a public or private API. The only difference is the availability of the API to Gatsby to query the data.
Gatsby の視点からすると、パブリック API とプライベート API のどちらからの取得にも違いはありません。唯一の違いは、データを取得するために Gatsby が API を利用できることです。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ日本語の意味が通ってないです。
「API を利用できること」→ difference is the availability「(権限的に)API を利用できるかどうか」を伝える内容に修正お願いします。

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 20, 2020
@nzws
Copy link
Contributor Author

nzws commented Jan 20, 2020

2つとも修正しました🙇‍♂️

@nzws nzws requested a review from uetchy January 20, 2020 10:24
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green and removed status: awaiting author response A pull request that is awaiting author's response status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 20, 2020
@smorimoto smorimoto merged commit 8f014e8 into gatsbyjs:master Jan 20, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 20, 2020

Holy buckets, @nzws — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@nzws nzws deleted the docs/sourcing-from-private-apis branch January 20, 2020 11:10
@uetchy uetchy removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned status: ready to merge A pull request that can be merged once CI is green labels Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants