Translation: docs/themes/getting-started #77

hoshikitsunoda · 2020-01-17T19:28:03Z

概要

Translation for: https://www.gatsbyjs.org/docs/themes/getting-started/

チェックリスト

翻訳スタイルガイドに目を通しました。
Translation Guide に目を通しました。
textlint を使って校正を行いました（推奨）
Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

uetchy · 2020-01-24T15:14:32Z

package.json

    ]
  },
+
+  "version": "0.0.0",


翻訳以外の変更を含める場合は、その部分を切り出して新たなPRを送ってください。

訂正ありがとうございます！部分的に切り出して新たなPRを送るということをしたことがないのですが、一旦この修正前までrevertして新しいブランチを作ってからPRを送るんですか？

選択的に変更を削除して新しいヒストリーを作り直し、それをforce pushする形になりますね。
このPRには翻訳部分のみを含む形にします。
もし難しければこちらでやるので言ってください。

遅くなりました。今package.jsonを2commit前に戻しインラインコードを修正してpushしたんですがこれであってますか？まだfile changedが2になっているのでpackage.jsonは完全に消さないといけないですか？

package.json への変更は含めないようにお願いします！

uetchy · 2020-01-24T15:52:19Z

docs/docs/themes/getting-started.md

+### 1. テーマをインストールし設定する

-When you use a starter that's built with a theme, you will often see that you're initially presented with a lighter weight `gatsby-config.js`. Themes start doing their magic when installed via the `plugins` array:
+テーマを使用して作られたスターターの`gatsby-config.js`は最初軽く見えることが多くあります。テーマはプラグイン配列からインストールされたときに真価を発揮します。


plugins のようなインラインコードは翻訳しないでください。

uetchy · 2020-01-26T14:23:37Z

package.json

@@ -1,42 +1,34 @@
 {


package.jsonが古いものにロールバックされている状態です。自力で解決するのが困難であれば教えてください。こちらで修正します。

ありがとうございます。ロールバックするものだと思ってました。。やり方がわからないので手伝ってもらえると助かります。よろしくお願いします！

uetchy · 2020-01-27T03:09:30Z

@hoshikitsunoda package.jsonに対するコミットをドロップして、ついでに最新のmasterにrebaseしました👍

uetchy

👍

docs/docs/themes/getting-started.md

Co-Authored-By: Yasuaki Uechi <[email protected]>

hoshikitsunoda · 2020-01-27T04:59:39Z

ありがとうございます！お手数おかけしました。。さきほどsuggestionをcommitしました！
よければでいいのですが、どういうコマンドを入力してコミットのドロップとrebaseをしたのか教えてもらってもいいですか？

uetchy · 2020-01-27T09:57:27Z

@hoshikitsunoda Forkを使ってinteractive rebaseを行いました👍

hirotaka

内容は大丈夫なのですが、体裁に関するところだけ、いくつかSuggestionをリクエストさせていただいのでご確認お願いします。

docs/docs/themes/getting-started.md

Co-Authored-By: Hirotaka Mizutani <[email protected]>

hoshikitsunoda · 2020-01-28T10:46:29Z

内容は大丈夫なのですが、体裁に関するところだけ、いくつかSuggestionをリクエストさせていただいのでご確認お願いします。

見逃してました。ありがとうございます。suggestion commitさせていただきました。よろしくお願いします！

hirotaka

ありがとうございます！LGTM 👍

uetchy

🎉

gatsbot · 2020-01-28T10:55:56Z

Holy buckets, @hoshikitsunoda — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

hoshikitsunoda requested review from Naturalclar, hirotaka, smorimoto and uetchy as code owners January 17, 2020 19:28

hoshikitsunoda changed the title ~~Docs/themes/getting started~~ Translattion: docs/themes/getting-started Jan 17, 2020

hoshikitsunoda changed the title ~~Translattion: docs/themes/getting-started~~ Translation: docs/themes/getting-started Jan 17, 2020

smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 18, 2020

gatsbybot mentioned this pull request Jan 19, 2020

☂️ Japanese Translation Progress (Core / Docs / Tutorials) #1

Closed

uetchy reviewed Jan 24, 2020

View reviewed changes

uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 25, 2020

smorimoto removed the status: awaiting author response A pull request that is awaiting author's response label Jan 26, 2020

smorimoto requested a review from uetchy January 26, 2020 14:17

uetchy reviewed Jan 26, 2020

View reviewed changes

seiki tsunoda added 3 commits January 27, 2020 12:07

translated themes/getting-started

e1b2a70

removed colons

a20b25f

added spacing before backtick

8636ae2

uetchy reviewed Jan 27, 2020

View reviewed changes

docs/docs/themes/getting-started.md Outdated Show resolved Hide resolved

docs/docs/themes/getting-started.md Outdated Show resolved Hide resolved

uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 27, 2020

hoshikitsunoda and others added 2 commits January 26, 2020 20:56

Update docs/docs/themes/getting-started.md

0ac997e

Co-Authored-By: Yasuaki Uechi <[email protected]>

Update docs/docs/themes/getting-started.md

2c525b6

Co-Authored-By: Yasuaki Uechi <[email protected]>

smorimoto added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 27, 2020

uetchy previously approved these changes Jan 27, 2020

View reviewed changes

uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 27, 2020

hirotaka suggested changes Jan 28, 2020

View reviewed changes

docs/docs/themes/getting-started.md Outdated Show resolved Hide resolved

docs/docs/themes/getting-started.md Outdated Show resolved Hide resolved

docs/docs/themes/getting-started.md Outdated Show resolved Hide resolved

Update docs/docs/themes/getting-started.md

db19c38

Co-Authored-By: Hirotaka Mizutani <[email protected]>

hoshikitsunoda dismissed stale reviews from uetchy via db19c38 January 28, 2020 10:44

hoshikitsunoda and others added 2 commits January 28, 2020 02:44

Update docs/docs/themes/getting-started.md

5ec8cc3

Co-Authored-By: Hirotaka Mizutani <[email protected]>

Update docs/docs/themes/getting-started.md

534f962

Co-Authored-By: Hirotaka Mizutani <[email protected]>

hirotaka approved these changes Jan 28, 2020

View reviewed changes

hirotaka requested a review from uetchy January 28, 2020 10:47

uetchy approved these changes Jan 28, 2020

View reviewed changes

uetchy merged commit a006151 into gatsbyjs:master Jan 28, 2020

uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 28, 2020

Translation: docs/themes/getting-started #77

Translation: docs/themes/getting-started #77

Uh oh!

Conversation

hoshikitsunoda commented Jan 17, 2020

概要

チェックリスト

Uh oh!

uetchy Jan 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoshikitsunoda Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

uetchy Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

hoshikitsunoda Jan 26, 2020

Choose a reason for hiding this comment

Uh oh!

uetchy Jan 26, 2020

Choose a reason for hiding this comment

Uh oh!

uetchy Jan 24, 2020

Choose a reason for hiding this comment

Uh oh!

uetchy Jan 26, 2020

Choose a reason for hiding this comment

Uh oh!

hoshikitsunoda Jan 26, 2020

Choose a reason for hiding this comment

Uh oh!

uetchy commented Jan 27, 2020

Uh oh!

uetchy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hoshikitsunoda commented Jan 27, 2020

Uh oh!

uetchy commented Jan 27, 2020

Uh oh!

hirotaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hoshikitsunoda commented Jan 28, 2020

Uh oh!

hirotaka left a comment

Choose a reason for hiding this comment

Uh oh!

uetchy left a comment

Choose a reason for hiding this comment

Uh oh!

gatsbot bot commented Jan 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

uetchy Jan 24, 2020 •

edited

Loading